fix(helm): supervisor OTLP endpoint resolves cross-namespace#3504
fix(helm): supervisor OTLP endpoint resolves cross-namespace#3504
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2026-03-27T22:45:00.623ZApplied to files:
🔇 Additional comments (1)
WalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
🧭 Helm Chart Prerelease PublishedVersion: Install: helm upgrade --install trigger \
oci://ghcr.io/triggerdotdev/charts/trigger \
--version "4.4.5-pr3504.7269d4f"
|
|
ready |
Reported by external contributor. The supervisor template hardcoded a short DNS name for
OTEL_EXPORTER_OTLP_ENDPOINT, which the supervisor then propagates verbatim into runner pods (apps/supervisor/src/workloadManager/kubernetes.ts:196). When runners are spawned in a different namespace viasupervisor.config.kubernetes.namespace, the short name doesn't resolve and span/log export silently fails - runs complete fine but the dashboard shows nothing.Same FQDN pattern the chart already uses for
TRIGGER_WORKLOAD_API_DOMAIN(line 203). Verified withhelm template trigger . --namespace my-ns- rendershttp://trigger-webapp.my-ns.svc.cluster.local:3030/otel.Cheers Niels