test(effect): Add Effect v3 compatibility tests for backwards compat#20389
Draft
JPeer264 wants to merge 1 commit intojp/effect-v4from
Draft
test(effect): Add Effect v3 compatibility tests for backwards compat#20389JPeer264 wants to merge 1 commit intojp/effect-v4from
JPeer264 wants to merge 1 commit intojp/effect-v4from
Conversation
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Effect v3 compatibility tests as own folder. We can't really leave them inside
packages/effect, as there we need to have Effect v4 asdevDependency, so the old version can't be used nor tested anymore.Also the new
effect-3-compatibility-testsare not included in the yarn workspace. Here yarn somehow can't have two different effect versions installed and the tests just wouldn't work correctly (so I did an ownyarn.lockinside this folder to keep them separate. In case we would move over topnpmor something else we could try to add it as part of the workspace)I basically copied over everything inside
packages/effect/testinto this folder and changed thecreateMetricsFlusher()toyield* TestClock.adjust('10 seconds');, as this is more reliable and wouldn't rely on any internal testing functionality.