E2E - QA: init, deploy, versions list, config link, 2nd deploy#7367
E2E - QA: init, deploy, versions list, config link, 2nd deploy#7367phyllis-sy-wu merged 2 commits intomainfrom
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/analytics.d.ts@@ -19,7 +19,6 @@ interface EnvironmentData {
env_device_id: string;
env_cloud: string;
env_package_manager: string;
- env_install_package_manager: string;
env_is_global: boolean;
env_auth_method: string;
env_is_wsl: boolean;
packages/cli-kit/dist/public/node/monorail.d.ts@@ -2,7 +2,7 @@ import { JsonMap } from '../../private/common/json.js';
import { DeepRequired } from '../common/ts/deep-required.js';
export { DeepRequired };
type Optional<T> = T | null;
-export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.22";
+export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.21";
export interface Schemas {
[MONORAIL_COMMAND_TOPIC]: {
sensitive: {
@@ -129,7 +129,6 @@ export interface Schemas {
env_ci_platform?: Optional<string>;
env_device_id?: Optional<string>;
env_package_manager?: Optional<string>;
- env_install_package_manager?: Optional<string>;
env_package_manager_workspaces?: Optional<boolean>;
env_plugin_installed_any_custom?: Optional<boolean>;
env_plugin_installed_shopify?: Optional<string>;
|
9d0a3aa to
bfb1932
Compare
26a7e70 to
95f628a
Compare
95f628a to
f0005dd
Compare
bfb1932 to
d892ee8
Compare
f0005dd to
633cc3c
Compare
633cc3c to
8e559ab
Compare
21fd11c to
64ab746
Compare
64ab746 to
9fdc90b
Compare
8e559ab to
64d0528
Compare
64d0528 to
e952944
Compare
9fdc90b to
9ef5dba
Compare
9ef5dba to
391e146
Compare
e952944 to
0cff016
Compare
391e146 to
3e397ce
Compare
0cff016 to
7bc783a
Compare
byrichardpowell
left a comment
There was a problem hiding this comment.
Approving with a few suggestions:
1) File-scope eslint-disable no-restricted-imports is too broad. The prior // eslint-disable-line was surgical — just the path import. The new file-level disable silences the rule for every current
and future import in the file. Prefer restoring the per-line form:
import * as path from 'path' // eslint-disable-line no-restricted-imports
- Tighten the Step 4 link assertion. expect(linkOutput).toContain('is now linked to') passes even if link succeeded against the wrong app. The CLI banner includes the app name — assert it:
expect(linkOutput).toContain(`is now linked to "${secondaryAppName}"`)
7bc783a to
b4842d8
Compare
3e397ce to
8f355b6
Compare
8f355b6 to
47ed438
Compare
b4842d8 to
36be687
Compare
|
Fixed on latest update! Thanks for spotting these issues. |

WHY are these changes introduced?
Automates test A of the manual QA flow (tracked in #7368 / sub-issue #7369). The existing
app-deploy.spec.tsonly covered a single init→deploy→versions-list cycle. Test A extends it to the full manual flow, adding coverage for:app config linkcreating a second app (interactive PTY prompts)This closes the gap for the
config link-to-new-app codepath, which previously had no E2E coverage.WHAT is this pull request doing?
Expands
tests/app-deploy.spec.tsto the full A scope:shopify app init --template reactRouter(primary app)shopify app deploy --version v1+ assert active on primaryshopify app versions list --json+ assertversionTagmatchesshopify app config link --config secondary(via PTY) → creates a new app within the primary app's organizationshopify app deploy --config secondary --version v2+ assert active on secondaryshopify app versions list --config secondary --json+ assert isolation from primaryAlso adds helpers in
setup/app.ts(config-link PTY driver, JSON-mode versions list, shared assertion for active-version checks) reused across this and future A–F tests.How to test your changes?
Requires
.envwithE2E_ACCOUNT_EMAIL,E2E_ACCOUNT_PASSWORD,E2E_ORG_ID.Runtime ~2 min. Resources created during the test are the two apps (primary + secondary) — teardown deletes both automatically.
Example
Expand for complete log
Post-release steps
N/A
Checklist