Skip to content

E2E: remove dead code#7360

Merged
phyllis-sy-wu merged 1 commit intomainfrom
psyw-0421-E2E-remove-dead-code
Apr 23, 2026
Merged

E2E: remove dead code#7360
phyllis-sy-wu merged 1 commit intomainfrom
psyw-0421-E2E-remove-dead-code

Conversation

@phyllis-sy-wu
Copy link
Copy Markdown
Contributor

@phyllis-sy-wu phyllis-sy-wu commented Apr 21, 2026

WHY are these changes introduced?

These scripts are unused — nothing imports or calls them. They've been replaced by cleanup-apps.ts and the test fixtures that create apps directly.

WHAT is this pull request doing?

Removes two dead scripts from packages/e2e/scripts/:

  • cleanup-test-apps.ts — original cleanup script, superseded by cleanup-apps.ts (E2E: utility - cleanup apps #7356)
  • create-test-apps.ts — standalone app creation utility, superseded by test fixtures (appTestFixture in setup/app.ts)

Neither file is imported, referenced in package.json, or called from any other file in the repo.

How to test your changes?

grep -r "cleanup-test-apps\|create-test-apps" packages/e2e/ --include="*.ts" --include="*.json"
# Should return nothing

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

phyllis-sy-wu commented Apr 21, 2026

@github-actions github-actions Bot added the devtools-gardener Post the issue or PR to Slack for the gardener label Apr 21, 2026
@phyllis-sy-wu phyllis-sy-wu marked this pull request as ready for review April 21, 2026 16:24
@phyllis-sy-wu phyllis-sy-wu requested a review from a team as a code owner April 21, 2026 16:24
@phyllis-sy-wu phyllis-sy-wu changed the base branch from psyw-0421-E2E-teardown-polish to graphite-base/7360 April 21, 2026 18:44
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0421-E2E-remove-dead-code branch from bfdfaee to f569707 Compare April 22, 2026 05:55
@phyllis-sy-wu phyllis-sy-wu changed the base branch from graphite-base/7360 to psyw-0421-E2E-teardown-polish April 22, 2026 05:56
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0421-E2E-teardown-polish branch from e2f6c6d to d892ee8 Compare April 22, 2026 14:52
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0421-E2E-remove-dead-code branch from f569707 to b6b2479 Compare April 22, 2026 14:52
@phyllis-sy-wu phyllis-sy-wu changed the base branch from psyw-0421-E2E-teardown-polish to graphite-base/7360 April 22, 2026 15:16
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0421-E2E-remove-dead-code branch from b6b2479 to a7aea9b Compare April 22, 2026 15:16
@phyllis-sy-wu phyllis-sy-wu changed the base branch from graphite-base/7360 to main April 22, 2026 15:16
@phyllis-sy-wu phyllis-sy-wu linked an issue Apr 22, 2026 that may be closed by this pull request
@phyllis-sy-wu phyllis-sy-wu added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 975bf1a Apr 23, 2026
46 of 47 checks passed
@phyllis-sy-wu phyllis-sy-wu deleted the psyw-0421-E2E-remove-dead-code branch April 23, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devtools-gardener Post the issue or PR to Slack for the gardener

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E: Cleanup unused codes

2 participants