Skip to content

Space Invaders: reclaim off-screen bullets, enforce black playfield, preserve ESC exit #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbampton merged 3 commits into from
Apr 19, 2026
+16 −1
Merged

Space Invaders: reclaim off-screen bullets, enforce black playfield, preserve ESC exit #441

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c292564
Space Invaders: cleanup offscreen bullets and black canvas background
Copilot Apr 19, 2026
c99ea46
Space Invaders: extract bullet cleanup buffer constant
Copilot Apr 19, 2026
29ea11a
Merge branch 'main' into copilot/improve-space-invaders-game
jbampton Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/assets/js/games/space-invaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
const SpaceInvaders = (() => {
const ALIEN_ROWS = ["👾", "👽", "🛸", "🐙", "👾"];
const GAME_ID = "space-invaders";
const BULLET_CLEANUP_BUFFER = 40;

// ─── Public entry-point ──────────────────────────────────────────────────

Expand All @@ -36,6 +37,7 @@ const SpaceInvaders = (() => {
height: "100vh",
zIndex: "10000",
pointerEvents: "auto",
background: "#000000",
});
document.body.appendChild(canvas);

Expand All @@ -44,7 +46,8 @@ const SpaceInvaders = (() => {
canvas: canvas,
width: window.innerWidth,
height: window.innerHeight,
transparent: true,
transparent: false,
backgroundColor: "#000000",
physics: {
default: "arcade",
arcade: { gravity: { y: 0 }, debug: false },
Expand Down Expand Up @@ -79,6 +82,18 @@ const SpaceInvaders = (() => {
if (this.si_cursors.space.isDown) {
_fireBullet(this);
}

const bullets = this.si_bullets?.getChildren?.() || [];
bullets.forEach((bullet) => {
if (!bullet.active) return;
if (
bullet.y < -BULLET_CLEANUP_BUFFER ||
bullet.x < -BULLET_CLEANUP_BUFFER ||
bullet.x > this.scale.width + BULLET_CLEANUP_BUFFER
) {
bullet.destroy();
}
});
}

// ─── Game setup ──────────────────────────────────────────────────────────
Expand Down
Loading