Fix missing default type for poisson and geometric template parameter T#2893
Open
ssam18 wants to merge 5 commits intoxtensor-stack:masterfrom
Open
Fix missing default type for poisson and geometric template parameter T#2893ssam18 wants to merge 5 commits intoxtensor-stack:masterfrom
ssam18 wants to merge 5 commits intoxtensor-stack:masterfrom
Conversation
…tensor-stack#2871) This commit addresses GitHub issue xtensor-stack#2871 where using 'auto' with xtensor reducer functions (like amax, sum with keep_dims) in functions causes crashes or incorrect results in optimized builds. The issue is that lazy expressions hold references to local variables. When intermediate results are stored with 'auto', these references become dangling when the function returns, leading to undefined behavior. Fixes xtensor-stack#2871
- Only force evaluation of the returned expression; intermediate lazy expressions are safe as long as they do not outlive the function - Use auto for shifted/expVals/sumExp in the doc example and tests - Remove misleading "Alternatively" sections (eval on intermediates is not required; evaluation_strategy::immediate does not fix the issue) - Fix logSoftmax_eval test variant to drop unnecessary xt::eval wrappers
A lazy reducer (e.g. xt::sum with keep_dims) cannot be safely used as an operand in a subsequent element-wise expression without first materializing it. Element-wise lazy expressions (shifted, expVals) are safe as auto, but the reducer result (sumExp) must be assigned to xt::xtensor or wrapped in xt::eval before use. This fixes the CI test failure in issue_2871_intermediate_result_handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xt::random::poissonandxt::random::geometricboth useTonly internally (as the distribution's output type), so the compiler has no way to deduce it from the call site. Adding= intas the default matches the underlyingstd::poisson_distributionandstd::geometric_distributiondefaults and lets users call these functions without spelling out the type every time. Fixes #2884.