Skip to content

Fix SVE dynamic dispatch ODR violation #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntoinePrv merged 5 commits into from
Apr 21, 2026
Merged

Fix SVE dynamic dispatch ODR violation #1311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49b6b07
Add missing inline
AntoinePrv Apr 20, 2026
509020d
Rename xsimd_inline > xsimd_macros
AntoinePrv Apr 20, 2026
3c039dd
Avoid ODR violation in SVE dynamic dispatch
AntoinePrv Apr 20, 2026
4371d66
Fmt
AntoinePrv Apr 21, 2026
ddc883b
Remove unused include
AntoinePrv Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion benchmark/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@
* The full license is in the file LICENSE, distributed with this software. *
****************************************************************************/

#include "xsimd_benchmark.hpp"
#include <iostream>
#include <map>
#include <string>

#include "xsimd_benchmark.hpp"

void benchmark_operation()
{
Expand Down
1 change: 0 additions & 1 deletion benchmark/xsimd_benchmark.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xsimd/arch/xsimd_scalar.hpp"
#include "xsimd/xsimd.hpp"
#include <chrono>
#include <iostream>
#include <string>
#include <vector>

Expand Down
2 changes: 1 addition & 1 deletion include/xsimd/arch/common/xsimd_common_swizzle.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include <cstdint>
#include <type_traits>

#include "../../config/xsimd_inline.hpp"
#include "../../config/xsimd_macros.hpp"

namespace xsimd
{
Expand Down
2 changes: 1 addition & 1 deletion include/xsimd/arch/utils/shifts.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#ifndef XSIMD_UTILS_SHIFTS_HPP
#define XSIMD_UTILS_SHIFTS_HPP

#include "../../config/xsimd_inline.hpp"
#include "../../config/xsimd_macros.hpp"
#include "../../types/xsimd_batch.hpp"
#include "../../types/xsimd_batch_constant.hpp"
#include "../../types/xsimd_traits.hpp"
Expand Down
12 changes: 6 additions & 6 deletions include/xsimd/arch/xsimd_rvv.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,12 +369,12 @@ namespace xsimd
using as_float_relaxed_t = typename as_float_relaxed<sizeof(T)>::type;

template <class T, class U>
rvv_reg_t<T, U::width> rvvreinterpret(U const& arg) noexcept
XSIMD_INLINE rvv_reg_t<T, U::width> rvvreinterpret(U const& arg) noexcept
{
return rvv_reg_t<T, U::width>(arg, types::detail::XSIMD_RVV_BITCAST);
}
template <class T, class A, class U>
rvv_reg_t<T, A::width> rvvreinterpret(batch<U, A> const& arg) noexcept
XSIMD_INLINE rvv_reg_t<T, A::width> rvvreinterpret(batch<U, A> const& arg) noexcept
{
typename batch<U, A>::register_type r = arg;
return rvvreinterpret<T>(r);
Expand Down Expand Up @@ -519,23 +519,23 @@ namespace xsimd
XSIMD_RVV_OVERLOAD(rvvget_hi_, (__riscv_vget_ XSIMD_RVV_TSM), _DROP_1ST_CUSTOM_ARGS_NOVL, vec(T, wide_vec), args..., 1)

template <class T, size_t W, std::enable_if_t<W >= types::detail::rvv_width_m1, int> = 0>
rvv_reg_t<T, W> rvvget_lo(rvv_reg_t<T, W * 2> const& vv) noexcept
XSIMD_INLINE rvv_reg_t<T, W> rvvget_lo(rvv_reg_t<T, W * 2> const& vv) noexcept
{
typename rvv_reg_t<T, W>::register_type tmp = rvvget_lo_(T {}, vv);
return tmp;
}
template <class T, size_t W, std::enable_if_t<W >= types::detail::rvv_width_m1, int> = 0>
rvv_reg_t<T, W> rvvget_hi(rvv_reg_t<T, W * 2> const& vv) noexcept
XSIMD_INLINE rvv_reg_t<T, W> rvvget_hi(rvv_reg_t<T, W * 2> const& vv) noexcept
{
typename rvv_reg_t<T, W>::register_type tmp = rvvget_hi_(T {}, vv);
return tmp;
}
template <class T, size_t W, std::enable_if_t<W<types::detail::rvv_width_m1, int> = 0> rvv_reg_t<T, W> rvvget_lo(rvv_reg_t<T, W * 2> const& vv) noexcept
template <class T, size_t W, std::enable_if_t<W<types::detail::rvv_width_m1, int> = 0> XSIMD_INLINE rvv_reg_t<T, W> rvvget_lo(rvv_reg_t<T, W * 2> const& vv) noexcept
{
typename rvv_reg_t<T, W>::register_type tmp = vv;
return tmp;
}
template <class T, size_t W, std::enable_if_t<W<types::detail::rvv_width_m1, int> = 0> rvv_reg_t<T, W> rvvget_hi(rvv_reg_t<T, W * 2> const& vv) noexcept
template <class T, size_t W, std::enable_if_t<W<types::detail::rvv_width_m1, int> = 0> XSIMD_INLINE rvv_reg_t<T, W> rvvget_hi(rvv_reg_t<T, W * 2> const& vv) noexcept
{
return __riscv_vslidedown(vv, vv.vl / 2, vv.vl);
}
Expand Down
2 changes: 1 addition & 1 deletion include/xsimd/arch/xsimd_scalar.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include <limits>
#include <type_traits>

#include "xsimd/config/xsimd_inline.hpp"
#include "xsimd/config/xsimd_macros.hpp"

#ifdef XSIMD_ENABLE_XTL_COMPLEX
#include "xtl/xcomplex.hpp"
Expand Down
Loading
Loading