Merged
Conversation
serge-sans-paille
force-pushed
the
feature/clang-tidy
branch
from
38991b4 to
c72335d
Compare
serge-sans-paille
force-pushed
the
feature/clang-tidy
branch
from
c72335d to
7c698a0
Compare
serge-sans-paille
force-pushed
the
feature/clang-tidy
branch
from
0acb75d to
c2174fe
Compare
Contributor
Author
|
@JohanMabille I'm super happy with those checks, the only problem is that this PR only enables it for x86_64 and common files. |
JohanMabille
approved these changes
Apr 20, 2026
Member
JohanMabille
left a comment
JohanMabille
left a comment
There was a problem hiding this comment.
That's better than nothing and that gives us hints about what to search for and fix for other archs (assuming we've been systematic in our coding style ;))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.