Add warning to make non-registered channelOpenCb visible#954
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom Apr 24, 2026
Merged
Add warning to make non-registered channelOpenCb visible#954ejohnstown merged 1 commit intowolfSSL:masterfrom
ejohnstown merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a warning log in the channel-open handling path to make it visible when a channelOpenCb callback has not been registered, while preserving the existing behavior of accepting channel opens by default.
Changes:
- Emit a
WS_LOG_WARNmessage whenssh->ctx->channelOpenCbis not set duringDoChannelOpen().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
padelsbach
approved these changes
Apr 24, 2026
ejohnstown
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the waring log for non-registered channelOpenCb usage.
This doesn't break current program flow but make users aware of it.