Improve intersect_by_rank performance#7744
Draft
robert3005 wants to merge 1 commit intodevelopfrom
Draft
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Contributor
Author
|
I will go over this tomorrow @joseph-isaacs I looked at #7098 and #7393 which both optimised slightly different cases of this function. I tried to combine the two. |
Merging this PR will degrade performance by 37.03%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | for[10M_u16] |
94.8 µs | 150.6 µs | -37.03% |
| ❌ | WallTime | runend[10M_i32_runlen_10] |
159.4 µs | 192.5 µs | -17.17% |
| ❌ | WallTime | dict[10M_u32_values_u16_codes] |
146.5 µs | 181.6 µs | -19.3% |
| ⚡ | WallTime | mix[100%_in/0%_out] |
500.7 µs | 451.6 µs | +10.88% |
| ⚡ | WallTime | dynamic_dispatch_u32[10M] |
142.3 µs | 96.3 µs | +47.87% |
| ⚡ | Simulation | decompress_rd[f32, (10000, 0.0)] |
94.6 µs | 85.7 µs | +10.36% |
| ⚡ | Simulation | decompress_rd[f32, (100000, 0.0)] |
583.5 µs | 495.6 µs | +17.74% |
| ❌ | Simulation | decompress_rd[f32, (100000, 0.01)] |
495.1 µs | 582.5 µs | -15.01% |
| ❌ | Simulation | decompress_rd[f32, (100000, 0.1)] |
495.1 µs | 582.5 µs | -15.01% |
| ⚡ | Simulation | decompress_rd[f32, (10000, 0.1)] |
90.2 µs | 81.8 µs | +10.25% |
| ⚡ | Simulation | decompress_rd[f32, (10000, 0.01)] |
90.1 µs | 81.9 µs | +10.06% |
| ⚡ | Simulation | decompress_rd[f64, (10000, 0.0)] |
138.5 µs | 122.1 µs | +13.43% |
| ⚡ | Simulation | decompress_rd[f64, (10000, 0.1)] |
138.7 µs | 122.1 µs | +13.61% |
| ❌ | Simulation | decompress_rd[f64, (100000, 0.1)] |
842.5 µs | 1,020.7 µs | -17.46% |
| ⚡ | Simulation | decompress_rd[f64, (10000, 0.01)] |
138.6 µs | 121.9 µs | +13.69% |
| ❌ | Simulation | decompress_rd[f64, (100000, 0.01)] |
842.6 µs | 1,020.5 µs | -17.44% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
246.1 ns | 275.3 ns | -10.6% |
Comparing rk/intersect-by-rank (8551137) with develop (cb9b138)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We never spent time and this is useful for merging selections and filters in
scans
Signed-off-by: Robert Kruszewski github@robertk.io