Conversation
Signed-off-by: Mikhail Kot <to@myrrc.dev>
bb4f9a2 to
2e6b98d
Compare
Merging this PR will degrade performance by 21.66%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | 10M_90%[10000000] |
198.5 µs | 226.5 µs | -12.36% |
| ❌ | WallTime | 10M_10%[1000000] |
133.5 µs | 170.4 µs | -21.66% |
| ⚡ | WallTime | 10M_50%[5000000] |
192.3 µs | 156.6 µs | +22.76% |
| ❌ | WallTime | dict[10M_u64_values_u8_codes] |
217 µs | 252.8 µs | -14.17% |
| ⚡ | WallTime | runend[10M_i32_runlen_100000] |
130 µs | 92.2 µs | +41.11% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
275.3 ns | 246.1 ns | +11.85% |
Comparing myrrc/duckdb-rm-cache (2e6b98d) with develop (deb7de0)
0ax1
approved these changes
Apr 30, 2026
robert3005
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't use it anyway as the right way is to use MultiFileSession
and get file footers out of it.