Skip to content

Remove duckdb object cache#7739

Merged
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-rm-cache
May 1, 2026
Merged

Remove duckdb object cache#7739
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-rm-cache

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Apr 30, 2026

We don't use it anyway as the right way is to use MultiFileSession
and get file footers out of it.

Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc requested a review from 0ax1 April 30, 2026 16:45
@myrrc myrrc force-pushed the myrrc/duckdb-rm-cache branch from bb4f9a2 to 2e6b98d Compare April 30, 2026 16:45
@myrrc myrrc added changelog/chore A trivial change ext/duckdb Relates to the DuckDB integration labels Apr 30, 2026
@myrrc myrrc enabled auto-merge (squash) April 30, 2026 16:46
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 30, 2026

Merging this PR will degrade performance by 21.66%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 3 regressed benchmarks
✅ 1192 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime 10M_90%[10000000] 198.5 µs 226.5 µs -12.36%
WallTime 10M_10%[1000000] 133.5 µs 170.4 µs -21.66%
WallTime 10M_50%[5000000] 192.3 µs 156.6 µs +22.76%
WallTime dict[10M_u64_values_u8_codes] 217 µs 252.8 µs -14.17%
WallTime runend[10M_i32_runlen_100000] 130 µs 92.2 µs +41.11%
Simulation bitwise_not_vortex_buffer_mut[128] 275.3 ns 246.1 ns +11.85%

Comparing myrrc/duckdb-rm-cache (2e6b98d) with develop (deb7de0)

Open in CodSpeed

@myrrc myrrc added changelog/skip Do not list PR in the changelog and removed changelog/chore A trivial change labels May 1, 2026
@myrrc myrrc merged commit c4feed7 into develop May 1, 2026
85 of 88 checks passed
@myrrc myrrc deleted the myrrc/duckdb-rm-cache branch May 1, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants