Skip to content

Ignore hanging test#7736

Closed
connortsui20 wants to merge 1 commit intodevelopfrom
ct/ignore-variant-hang-test
Closed

Ignore hanging test#7736
connortsui20 wants to merge 1 commit intodevelopfrom
ct/ignore-variant-hang-test

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

Summary

Ignores a hanging test that only hangs when running all tests cargo nextest run WITHOUT --all-features

Testing

N/A

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/fix A bug fix label Apr 30, 2026
@AdamGS
Copy link
Copy Markdown
Contributor

AdamGS commented Apr 30, 2026

would love to actually understand the underlying issue here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 30, 2026

Merging this PR will degrade performance by 28.03%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1196 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime runend[10M_i32_runlen_1000] 97.3 µs 135.2 µs -28.03%
WallTime dynamic_dispatch_u32[10M] 161.8 µs 109.6 µs +47.66%

Comparing ct/ignore-variant-hang-test (fdea5b3) with develop (128ce5f)

Open in CodSpeed

@connortsui20 connortsui20 marked this pull request as ready for review April 30, 2026 17:04
@connortsui20
Copy link
Copy Markdown
Contributor Author

ok so I just rebuilt and now it doesn't hang? Idk anymore it must have been something wrong with my build cache.

@connortsui20 connortsui20 deleted the ct/ignore-variant-hang-test branch April 30, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants