Skip to content

skip: remove parameter names from public api lock files#7728

Merged
joseph-isaacs merged 7 commits intodevelopfrom
ji/remove-param-names-public-lock
Apr 30, 2026
Merged

skip: remove parameter names from public api lock files#7728
joseph-isaacs merged 7 commits intodevelopfrom
ji/remove-param-names-public-lock

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

The names should append the public api signature.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
…mes-public-lock

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	vortex-array/public-api.lock
u
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the changelog/skip Do not list PR in the changelog label Apr 30, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 30, 2026

Merging this PR will improve performance by 47.66%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 1196 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime dynamic_dispatch_u32[10M] 161.8 µs 109.6 µs +47.66%
WallTime 10M_50%[5000000] 308.4 µs 276.4 µs +11.59%

Comparing ji/remove-param-names-public-lock (8e94855) with develop (128ce5f)

Open in CodSpeed

@joseph-isaacs joseph-isaacs marked this pull request as ready for review April 30, 2026 12:20
u
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@AdamGS
Copy link
Copy Markdown
Contributor

AdamGS commented Apr 30, 2026

can we just remove them? I don't think we actually look at them, and we don't use them to actually communicate API changes in the changelog/release notes.

u
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs
Copy link
Copy Markdown
Contributor Author

I agree with this, do we have a plan to make these useful? @robert3005 @gatesn

…mes-public-lock

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	encodings/fsst/public-api.lock
#	encodings/runend/public-api.lock
#	vortex-array/public-api.lock
#	vortex-tensor/public-api.lock
u
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit 573c995 into develop Apr 30, 2026
66 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/remove-param-names-public-lock branch April 30, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants