[WIP] feat(ffi): add literal expression support#7675
Draft
m7kss1 wants to merge 2 commits intovortex-data:developfrom
Draft
[WIP] feat(ffi): add literal expression support#7675m7kss1 wants to merge 2 commits intovortex-data:developfrom
m7kss1 wants to merge 2 commits intovortex-data:developfrom
Conversation
m7kss1
force-pushed
the
ffi/literal-expressions
branch
from
be85135 to
a40cc2c
Compare
m7kss1
changed the title
Contributor
Author
|
note: the current design is not ideal and will be changed. the ffi usage is expected to resemble something like this: vx_scalar *scalar = ...; // opaque class
vx_expression *expr = vx_expression_literal(scalar); |
myrrc
reviewed
Apr 28, 2026
| * The input string is borrowed and copied into the returned expression. | ||
| * If `value` is NULL, returns NULL. | ||
| */ | ||
| vx_expression *vx_expression_literal_utf8(const vx_string *value, bool is_nullable); |
Contributor
There was a problem hiding this comment.
Thanks for the contribution. I believe we want a dedicated vx_scalar type and not just expressions, as scalar are useful for other purposes.
myrrc
reviewed
Apr 28, 2026
| /// | ||
| /// `value` must point to one value of the C type corresponding to `ptype`. | ||
| /// For `PTYPE_F16`, the value is represented as `uint16_t`. | ||
| /// If `value` is NULL, returns NULL. |
Contributor
There was a problem hiding this comment.
Please add an API usage example. You may reference primitive array creation in src/array.rs
m7kss1
force-pushed
the
ffi/literal-expressions
branch
3 times, most recently
from
acd49c9 to
c1cae72
Compare
Signed-off-by: Dergousov Maksim <dergousovmaxim99@gmail.com>
Signed-off-by: Dergousov Maksim <dergousovmaxim99@gmail.com>
m7kss1
force-pushed
the
ffi/literal-expressions
branch
from
c1cae72 to
66bdcfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TBD
API Changes
TBD
Testing
Verifying new behavior and functionality works correctly.