Skip to content

azpainter: update to 3.0.12#60098

Merged
Duncaen merged 1 commit intovoid-linux:masterfrom
PrivacyIsARight:patch-5
Apr 23, 2026
Merged

azpainter: update to 3.0.12#60098
Duncaen merged 1 commit intovoid-linux:masterfrom
PrivacyIsARight:patch-5

Conversation

@PrivacyIsARight
Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64

Patch file does not appear to be necessary anymore. Additionally, the license is GPL-3.0 only not GPL-3.0 or later.

@PrivacyIsARight PrivacyIsARight marked this pull request as draft April 22, 2026 01:57
@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

Half passing half failing. I'll look into this.

@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

No I think I'm dumb. I removed the patch file because it compiles fine without it on x86_64 which is my build environment.

@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

The patch file is outdated. Removing it will only fix x86_64 builds.

@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

I will need to write a new patch file.

@PrivacyIsARight PrivacyIsARight force-pushed the patch-5 branch 2 times, most recently from cf2c3e3 to 5dbeff3 Compare April 23, 2026 01:05
@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

All builds now pass so I'll switch this to open. There are probably things that can be improved here and I'll work on them.

@PrivacyIsARight PrivacyIsARight marked this pull request as ready for review April 23, 2026 01:17
Comment thread srcpkgs/azpainter/template Outdated
Comment thread srcpkgs/azpainter/template Outdated
Comment thread srcpkgs/azpainter/template Outdated
Comment thread srcpkgs/azpainter/template Outdated
Comment thread srcpkgs/azpainter/template Outdated
@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

I figured there would be many issues.

@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

The readme confused me. It said "This software is released under the GPL3 License." Looking at the files I see that they do specifiy or later. I was focused on the configure section so I didn't notice.

@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

Looks much cleaner now. I spent all day yesterday and the day before working on this which is why the code is terrible and includes a bunch of redundant stuff. I didn't have time to review it.

@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

I've also noticed theres no changelog. I'll add that.

@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

Alright well I'm not even sure if it can be moved to the do_configure function. It might have to stay in do_build.
When moved to do_configure we get
ninja: Entering directory `build'
ninja: error: loading 'build.ninja': No such file or directory
=> ERROR: azpainter-3.0.12_1: do_build: 'ninja -C build ${makejobs}' exited with 1
=> ERROR: in do_build() at srcpkgs/azpainter/template:32
@Duncaen

@PrivacyIsARight
Copy link
Copy Markdown
Contributor Author

The current code looks about as clean as it's going to get. azpainter is just built in a way that we have to do strange stuff like this.

@Duncaen Duncaen force-pushed the patch-5 branch 2 times, most recently from ffe0c9e to aa7f16a Compare April 23, 2026 20:48
Co-authored-by: Duncaen <duncaen@voidlinux.org>
@Duncaen Duncaen merged commit 997abcd into void-linux:master Apr 23, 2026
8 checks passed
@PrivacyIsARight PrivacyIsARight deleted the patch-5 branch April 23, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants