Skip to content

build(deps): Included data job version in vdk-core/src/vdk/internal/builtin_plugins/run/job_input.py #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s0sharma wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build(deps): Included data job version in vdk-core/src/vdk/internal/builtin_plugins/run/job_input.py #3000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38c7d62
Included data job version in job_input.get_execution_properties() #1246
s0sharma Jan 6, 2024
91884ab
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/vdk-core/src/vdk/internal/builtin_plugins/run/job_input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from vdk.internal.core.errors import SkipRemainingStepsException
from vdk.internal.core.errors import UserCodeError
from vdk.internal.core.statestore import CommonStoreKeys
from vdk.internal.core.statestore import ExecutionStateStoreKeys


# TODO make this extensible so new job inputs can be added by plugins
Expand Down Expand Up @@ -182,6 +183,9 @@ def get_execution_properties(self) -> dict:
"pa__job_start_unixtime": str(int(start_time.timestamp())),
"pa__job_start_ts_expr": f"cast ({start_time.timestamp()} as timestamp)",
"pa__op_id": self.__statestore.get(CommonStoreKeys.OP_ID),
"pa__job_version": self.__statestore.get(
Copy link
Copy Markdown
Contributor

@murphp15 murphp15 Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be sure that it is always there?
Is it there even when ppl run a job locally?

ExecutionStateStoreKeys.JOB_GIT_HASH
),
}

def skip_remaining_steps(self) -> None:
Expand Down