Skip to content

docs(roadmap): add #423 — diff json staged/unstaged are raw diff strings, not structured file-change objects#2967

Closed
code-yeongyu wants to merge 1 commit intomainfrom
docs/roadmap-423-diff-json-staged-unstaged-raw-string
Closed

docs(roadmap): add #423 — diff json staged/unstaged are raw diff strings, not structured file-change objects#2967
code-yeongyu wants to merge 1 commit intomainfrom
docs/roadmap-423-diff-json-staged-unstaged-raw-string

Conversation

@code-yeongyu
Copy link
Copy Markdown
Collaborator

Pinpoint #423

diff --output-format json returns staged and unstaged as raw git diff prose strings.

Live output (with unstaged changes):

{"kind":"diff","result":"changes","staged":"","unstaged":"diff --git a/ROADMAP.md b/ROADMAP.md\nindex ca63e33..2e4b74e 100644\n--- a/ROADMAP.md\n+++ b/ROADMAP.md\n@@ ..."}

No files:[] array, no per-file metadata, no total_additions/total_deletions. Automation must parse raw unified diff format to know which files changed.

ROADMAP-only PR. No source/test changes.

@Yeachan-Heo
Copy link
Copy Markdown
Contributor

Review verdict: APPROVE

Inspected exact diff against origin/main: docs-only ROADMAP.md change (+2), no source/test/schema/runtime contract files touched. CI is green and merge state is CLEAN.

The #423 pinpoint is concrete and actionable: it identifies diff --output-format json returning staged/unstaged as raw unified diff strings, states the automation impact, and gives a specific fix shape (files[] with path, status, additions/deletions totals, old paths, and retained raw diff fields) plus regression expectations.

Non-duplicative enough: I found broader related diff/JSON contract material, especially #146 around the top-level claw diff typed envelope, but no exact duplicate for the specific raw staged/unstaged diff-string payload issue. Future implementation should reconcile #423 with #146 so the diff JSON contract does not fragment.

Merge risk: low. Blockers: none. Minor note only: the entry uses 2026-05-01 provenance while this review ran 2026-04-30 UTC; likely timezone/local-date provenance and not a blocker.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo
Copy link
Copy Markdown
Contributor

#2967 was reviewed and approved earlier, but it is now DIRTY after #2966 merged into main.

Please update/rebase the branch onto current main and let CI re-run. Once it is CLEAN/green again, this should be merge-ready unless the rebase changes the ROADMAP entry materially.


[repo owner's gaebal-gajae (clawdbot) 🦞]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants