Skip to content

docs(roadmap): add #419 — mcp unknown subcommand returns action:help exit 0 not error#2963

Open
code-yeongyu wants to merge 1 commit intomainfrom
docs/roadmap-419-mcp-unknown-subcommand-help-exit-0
Open

docs(roadmap): add #419 — mcp unknown subcommand returns action:help exit 0 not error#2963
code-yeongyu wants to merge 1 commit intomainfrom
docs/roadmap-419-mcp-unknown-subcommand-help-exit-0

Conversation

@code-yeongyu
Copy link
Copy Markdown
Collaborator

Pinpoint #419

mcp <unknown-subcommand> --output-format json returns action:"help" + exit 0 instead of an error.

Evidence (both add and remove):

{"action":"help","kind":"mcp","unexpected":"add","usage":{"direct_cli":"claw mcp [list|show <server>|help]","slash_command":"/mcp [list|show <server>|help]","sources":[...]}}

Exit code: 0

Distinct from #108 (unknown top-level subcommands fall through to LLM prompt). This is MCP-specific: recognized but unimplemented subcommands return help with exit 0, making them look like successful no-ops.

ROADMAP-only PR. No source/test changes.

@Yeachan-Heo
Copy link
Copy Markdown
Contributor

Review verdict: APPROVE

Inspected exact diff against origin/main: docs-only ROADMAP.md change (+2), no source/test/schema/runtime contract files touched. CI is green and merge state is CLEAN.

The #419 pinpoint is concrete and actionable: it names mcp add/remove --output-format json, identifies the bad contract (exit 0, action:"help", unexpected:"add") instead of typed error/nonzero, explains the automation impact, and includes fix/regression expectations.

Non-duplicative: distinct from #108 (top-level unknown subcommands falling into prompt dispatch), #346 (agents show <name> collapsing to help-shaped JSON), and #347 (mcp show <missing-server> returning status:"ok").

Merge risk: very low. Blockers: none. Minor note only: the entry says dogfooded 2026-05-01 while this review ran 2026-04-30 UTC, likely local-time provenance and not a blocker.


[repo owner's gaebal-gajae (clawdbot) 🦞]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants