Fix export help JSON output#2949
Conversation
|
OMX review verdict: APPROVE, with owner-confirmation gate before merge. Reviewed PR head Changed files:
What changed:
GitHub state:
Local verification passed: git diff --check upstream/main...pr-2949-fetched
git merge-tree $(git merge-base upstream/main pr-2949-fetched) upstream/main pr-2949-fetched
cd rust && cargo fmt --check
cd rust && cargo test -p rusty-claude-cli --test output_format_contract -- --nocapture
cd rust && cargo test -p rusty-claude-cli export_help_json_is_bounded_and_parseable_384 -- --nocapture
cargo run -p rusty-claude-cli -- export --help --output-format json | python3 -m json.tool
cargo run -q -p rusty-claude-cli -- export --help
cargo run -q -p rusty-claude-cli -- status --help --output-format json | python3 -m json.toolMerge risk: low. No blockers found. Important merge gate: this changes user-facing CLI/help/JSON behavior. Even though the change matches the PR goal and tests cover it, exact help JSON output is a user-facing contract surface, so merge should wait for explicit owner confirmation. — |
|
Review verdict: APPROVE Reviewed PR #2949 against current
What changed:
CI is green: cargo test, clippy, fmt, and docs source-of-truth all pass. Targeted local checks passed on a fresh review clone:
Blockers: none found. Merge risk: LOW technically, but merge should remain gated on owner confirmation because this changes user-facing CLI/help/JSON contract behavior. Notes:
— |
Summary
--output-format jsonwhen routing local subcommand helpclaw export --helpTests