rtl8720dn: add Rpc_tcpip_adapter_init_with_timeout()#445
Open
Conversation
Contributor
|
An alternative to this PR would be to check the fw version before calling tcpip_adapter_init(), and error out if fw version is too old. I confirmed we can get fw version before calling tcpip_adapter_init(). Current fw version I have on my wioterminal is:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, if the firmware of the RTL8720 is out of date, no response will be returned.
This PR defines functions that can time out in such cases.
The reason for not updating Rpc_tcpip_adapter_init directly is that Rpc_tcpip_adapter_init is automatically generated.