Skip to content

Dedicated channel for Pro plan#8751

Merged
0xFirekeeper merged 3 commits intomainfrom
firekeeper/pro
Apr 21, 2026
Merged

Dedicated channel for Pro plan#8751
0xFirekeeper merged 3 commits intomainfrom
firekeeper/pro

Conversation

@0xFirekeeper
Copy link
Copy Markdown
Member

@0xFirekeeper 0xFirekeeper commented Apr 21, 2026

PR-Codex overview

This PR focuses on updating the billing and plan information within the application, specifically refining descriptions, modifying plan options, and adjusting feature availability.

Detailed summary

  • Updated the PlanInfoCard to change the upgrade suggestion to only Growth.
  • Reduced the grid columns in Pricing from 4 to 3.
  • Modified descriptions and features for the Growth and Pro plans.
  • Changed the feature enablement logic in TeamDedicatedSupportCard to only require the Pro plan.
  • Adjusted the upgrade prompts to reflect the new plan structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Billing & Plans

    • Updated plan descriptions and feature lists for Growth, Pro, and Scale.
    • Removed the Starter plan from the pricing grid and adjusted layout accordingly.
    • Free-plan messaging now prompts upgrade to Growth only.
  • Dedicated Support

    • Dedicated Support now requires the Pro plan only.
    • Upgrade prompts and billing navigation highlight Pro when unavailable; Create Support Channel behavior adjusted for default vs. non-default team names.

@0xFirekeeper 0xFirekeeper requested review from a team as code owners April 21, 2026 16:41
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
thirdweb-www Ready Ready Preview, Comment Apr 21, 2026 5:29pm
4 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs-v2 Skipped Skipped Apr 21, 2026 5:29pm
nebula Skipped Skipped Apr 21, 2026 5:29pm
thirdweb_playground Skipped Skipped Apr 21, 2026 5:29pm
wallet-ui Skipped Skipped Apr 21, 2026 5:29pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

⚠️ No Changeset found

Latest commit: 99c4345

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the Dashboard Involves changes to the Dashboard. label Apr 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 70fb62d9-5489-4b4b-9391-cbdedb13d54e

📥 Commits

Reviewing files that changed from the base of the PR and between b8a0e11 and 99c4345.

📒 Files selected for processing (3)
  • apps/dashboard/src/@/utils/pricing.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/billing/components/PlanInfoCard.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/billing/components/Pricing.tsx
✅ Files skipped from review due to trivial changes (1)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/billing/components/PlanInfoCard.tsx

Walkthrough

Restricts dedicated support to the Pro plan and updates related UI/flows; revises TEAM_PLANS content for Growth/Pro/Scale; adjusts free-plan messaging to prompt upgrade to Growth only; and removes the Starter pricing card and its layout/highlight logic from the pricing grid.

Changes

Cohort / File(s) Summary
Dedicated Support & Save Button
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/_components/settings-cards/dedicated-support.tsx
Feature gating now requires team.billingPlan === "pro" (removed "scale"). Disabled-state text and billing navigation highlight reference Pro only. Save button: default-team-name path routes to team settings; non-default invokes createMutation.mutate(...) with disabled/isPending bound to createMutation.isPending.
Pricing data (TEAM_PLANS)
apps/dashboard/src/@/utils/pricing.tsx
Updated TEAM_PLANS exported constant: growth, pro, and scale plans have revised description and features; growth.subTitle set to null; nested feature arrays flattened/rewritten.
PlanInfoCard message
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/billing/components/PlanInfoCard.tsx
Free-plan copy updated: prompt now suggests upgrading to “Growth” only (removed “Starter or Growth” phrasing).
Pricing grid / Starter removal
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/billing/components/Pricing.tsx
Removed the Starter plan card; grid layout changed from 4 to 3 columns (xl:grid-cols-4xl:grid-cols-3); deleted highlightStarterPlan and stopped passing starter highlight props.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete and does not follow the repository's required template structure with issue tag, reviewer notes, and testing instructions. Add the Linear issue tag (TEAM-0000 format), include a 'Notes for the reviewer' section, and add a 'How to test' section with testing instructions.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the primary objective—restricting dedicated support to the Pro plan only—and is concise and specific.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch firekeeper/pro

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@apps/dashboard/src/app/`(app)/team/[team_slug]/(team)/~/settings/_components/settings-cards/dedicated-support.tsx:
- Line 34: The CTA logic currently prioritizes hasDefaultTeamName over feature
gating, causing non-Pro teams to see "Update Team Name" despite the card copy
requiring a Pro upgrade; update the saveButton determination in this component
so it first checks isFeatureEnabled (props.team.billingPlan === "pro") and only
when true falls back to hasDefaultTeamName to choose the "Update Team Name"
path, otherwise route to the upgrade flow; apply the same change to the other
CTA logic block referenced around the 126-153 region so both places enforce Pro
gating before the default-name check.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 60d190c0-e340-46fb-8dee-abfc3b36fe62

📥 Commits

Reviewing files that changed from the base of the PR and between dc07145 and 19410f8.

📒 Files selected for processing (1)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/_components/settings-cards/dedicated-support.tsx

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.76%. Comparing base (9017899) to head (99c4345).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8751      +/-   ##
==========================================
+ Coverage   52.71%   52.76%   +0.05%     
==========================================
  Files         934      934              
  Lines       62970    62970              
  Branches     4136     4142       +6     
==========================================
+ Hits        33195    33228      +33     
+ Misses      29677    29642      -35     
- Partials       98      100       +2     
Flag Coverage Δ
packages 52.76% <ø> (+0.05%) ⬆️
see 5 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel Bot temporarily deployed to Preview – thirdweb_playground April 21, 2026 16:48 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs-v2 April 21, 2026 16:48 Inactive
@vercel vercel Bot temporarily deployed to Preview – nebula April 21, 2026 16:48 Inactive
@vercel vercel Bot temporarily deployed to Preview – wallet-ui April 21, 2026 16:48 Inactive
@vercel vercel Bot temporarily deployed to Preview – wallet-ui April 21, 2026 17:23 Inactive
@vercel vercel Bot temporarily deployed to Preview – nebula April 21, 2026 17:23 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs-v2 April 21, 2026 17:23 Inactive
@vercel vercel Bot temporarily deployed to Preview – thirdweb_playground April 21, 2026 17:23 Inactive
@0xFirekeeper 0xFirekeeper merged commit eb07340 into main Apr 21, 2026
25 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/pro branch April 21, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant