Refactor workflow.py into package#1488
Draft
tconley1428 wants to merge 3 commits intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
temporalio/workflow.pywith atemporalio/workflow/package split into coarse internal modulestemporalio.workflowpackage surface for existing public and SDK-private imports_handlers.py, keeping_definition.pyfocused on workflow class definitionsTesting
env UV_CACHE_DIR=/tmp/uv-cache uv run ruff check temporalio/workflowenv UV_CACHE_DIR=/tmp/uv-cache uv run -m pytest -p no:rerunfailures tests/test_workflow.py -qenv UV_CACHE_DIR=/tmp/uv-cache uv run -m pytest -p no:rerunfailures tests/test_runtime.py -q -k "not different_runtimes and not runtime_task_fail_log_forwarding and not prometheus_histogram_bucket_overrides"Notes
uv.lockchanges unstaged and out of this PRtests/test_runtime.pycases because they require launching a local Temporal dev server in this sandbox