fix: add Elasticsearch visibility and modernize TLS samples#147
Open
chaptersix wants to merge 5 commits intomainfrom
Open
fix: add Elasticsearch visibility and modernize TLS samples#147chaptersix wants to merge 5 commits intomainfrom
chaptersix wants to merge 5 commits intomainfrom
Conversation
The tls-full sample failed to start with recent Temporal server versions because it lacked an Elasticsearch visibility store, which is now required. Changes to both tls-simple and tls-full: - Replace auto-setup image with server + admin-tools setup pattern - Add Elasticsearch service for advanced visibility - Add health checks and proper dependency ordering - Add create-namespace service using shared compose scripts - Update docker-compose to docker compose (v2) - Update READMEs for modern CLI usage Changes specific to tls-full: - Convert config_template.yaml from dockerize syntax to sprig env() syntax with # enable-template directive - Add TEMPORAL_SERVER_CONFIG_FILE_PATH for custom template loading - Remove obsolete kafka and unused DB backend sections - Add dynamicconfig/development-cass.yaml CI: - Add .github/workflows/tls.yaml to test both TLS samples - Runs on all pull requests Closes #100
Remove dead/unused sections: cassandra visibility datastore (ES is always used), ENABLE_ES conditional, metrics, dcRedirectionPolicy, archival, internal-frontend service, and hardcode ports that were never overridden. Also remove unused cassandra auth and TLS fields.
The Temporal server container runs as non-root, so mounted cert files need world-readable permissions. Also strips config_template.yaml down to only TLS-relevant sections.
Remove path filtering on pull_request so all jobs run on every PR. Merge tls.yaml jobs into compose.yaml and delete the separate file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the tls-full and tls-simple samples which fail to start with recent Temporal server versions. Modernizes both to follow the same patterns as the compose examples.
auto-setupimage withserver+admin-toolssetup patternconfig_template.yamlfrom dockerize syntax to sprigenv()with# enable-templatedirective, strip to TLS-relevant config onlycreate-namespaceservice using shared compose scriptscompose.yamldocker composeandtemporalCLICloses #100
Test plan
compose.yamlworkflow runs all compose + TLS jobs on this PR