Merged
Conversation
When the benchmark was converted from VLAs to heap allocation, the matching `free( x )` / `free( y )` calls were only added to `benchmark2`; `benchmark1` was left leaking both buffers on every invocation. Add the missing frees so both benchmarks release their allocations before returning. Ref: c5b700a
The strided example introduction dropped the verb "compute", producing "to differences of every other element". Match the peer `ddiff` README wording so the sentence is grammatical. Ref: 7c287ff
- Corrects `np.count_nonzeros` to `np.count_nonzero` (the actual NumPy API name; already spelled correctly elsewhere in the same table). - Removes a duplicated article in "Prepend a a specified number of singleton dimensions". Ref: 1be7bcc
…n` test The TypeScript declaration test carried a stray `/* eslint-disable space-in-parens */` directive absent from the sibling `reinterpret-complex64` and `reinterpret-complex128` tests; the file has no `space-in-parens` violations, so the directive is noise. Ref: be023a5
Planeshifter
changed the title
develop on 2026-04-21/22
Planeshifter
changed the title
kgryte
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-04-21 12:06:09 -0700 (6f2e5f611) and 2026-04-22 04:44:47 -0700 (78898df73).Findings were gathered by running four independent reviewers (two style-guide, two bug-hunting) across the union diff of the window; only issues reproducible from the diff alone and supported by a concrete fix are included. Each bullet cites the originating commit:
blas/ext/base/scusumkbn2c5b700a07:lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/benchmark/c/benchmark.length.crefactoredbenchmark1to heap-allocatexandybut forgot tofreethem; add matchingfreecalls beforereturn elapsed;to matchbenchmark2.blas/ext/base/sdiff7c287ff7a,lib/node_modules/@stdlib/blas/ext/base/sdiff/README.md): insert "compute" in sentence that reads "to differences of every other element" to matchddiffpeer implementation.docs/migration-guides/numpynp.count_nonzerostonp.count_nonzero(1be7bcc81,docs/migration-guides/numpy/README.md) and remove duplicated article in "Prepend a a specified number of singleton dimensions".ndarray/base/reinterpret-booleanlib/node_modules/@stdlib/ndarray/base/reinterpret-boolean/docs/types/test.ts(be023a59). The/* eslint-disable space-in-parens */comment serves no purpose — the file has no violations and sibling modules don't carry it.Related Issues
None.
Questions
No.
Other
Validation
Checked:
blas/ext/base,ndarray/base,napi,number/{u,}int32/base/muldw,blas/base/cgemv, and the NumPy migration guide additions againstdocs/style-guidesand sibling reference packages.sdiffforward-difference recursion, reinterpret casts,rot180indexing, N-API strided boolean matrix parsing) plus the mechanical VLA→heap C benchmark refactor (malloc/free balance, no double-free).Deliberately excluded (did not meet the high-signal bar):
NaN-guard removals innumber/{u,}int32/base/muldwand the redundant-isnandrop instats/base/dists/hypergeometric/mean— intentional per therefactor!/refactor:commit messages.reinterpretComplex64/reinterpretComplex128androt180/rot90— stdlib uses natural numeric ordering for dtype suffixes (see@stdlib/arraywhereComplex64ArrayprecedesComplex128Array), so the existing ordering is consistent.if ( total <= 1 || k >= total )inblas/ext/base/sdiff/lib/ndarray.jsandsrc/main.c— the peer packageblas/ext/base/ddiffcarries the identical guard, so revisiting it would require a scope expansion beyond this window.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was prepared by Claude Code: an automated 24-hour review pass spawned four independent reviewer agents (two style, two bug) against the union diff of commits merged to
develop, findings were cross-verified by re-reading the diff, and the surviving issues were fixed mechanically. All fixes are local, reversible, and reference-verified against sibling packages.@stdlib-js/reviewers