Skip to content

feat: add fft/base/fftpack/rffti#11467

Open
gunjjoshi wants to merge 11 commits intostdlib-js:developfrom
gunjjoshi:rffti-v2
Open

feat: add fft/base/fftpack/rffti#11467
gunjjoshi wants to merge 11 commits intostdlib-js:developfrom
gunjjoshi:rffti-v2

Conversation

@gunjjoshi
Copy link
Copy Markdown
Member

@gunjjoshi gunjjoshi commented Apr 15, 2026 •
edited
Loading

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used AI to understand how we generate C fixtures using FFTPACK.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 15, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 15, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
fft/base/fftpack/rffti $\color{green}406/406$
$\color{green}+0.00%$ 		$\color{green}12/12$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}406/406$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed Apr 15, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/test/test.js Outdated
kgryte
kgryte reviewed Apr 15, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/README.md Outdated
kgryte
kgryte reviewed Apr 15, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/docs/repl.txt Outdated
@gunjjoshi
test: use is-almost-same-value
274ca8e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gunjjoshi gunjjoshi requested a review from a team April 17, 2026 16:46
gunjjoshi and others added 4 commits April 17, 2026 22:18
@gunjjoshi @kgryte
Update README examples
e7f37ce 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
@gunjjoshi
docs: update examples
9ca9dbf 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gunjjoshi
docs: update repl text
cba0e7f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gunjjoshi
Merge branch 'develop' into rffti-v2
81286ff
@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Apr 17, 2026
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/docs/types/index.d.ts
@kgryte
style: add empty line
c27a175 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/docs/types/test.ts
@kgryte
style: add empty line
500b84b 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/docs/types/index.d.ts
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/docs/types/test.ts Outdated
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/docs/types/test.ts Outdated
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/examples/index.js
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/lib/main.js Outdated
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/lib/main.js Outdated
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/lib/main.js
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/lib/rffti1.js
Copy link
Copy Markdown
Member

@kgryte kgryte Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully understanding why this file differs from what we did in https://github.com/gunjjoshi/stdlib/blob/20edeac7d326443708e922a8aa99dc6a93baa3ef/lib/node_modules/%40stdlib/fft/base/fftpack/rffti/lib/rffti1.js. What is the reason for the various discrepancies?

kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/lib/rffti1.js
* @param {NonNegativeInteger} offsetF - starting index for `ifac`
* @returns {void}
*/
function rffti1( n, wa, strideW, offsetW, ifac, strideF, offsetF ) {
Copy link
Copy Markdown
Member

@kgryte kgryte Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would revisit this file. IMO, the changes in https://github.com/gunjjoshi/stdlib/blob/20edeac7d326443708e922a8aa99dc6a93baa3ef/lib/node_modules/%40stdlib/fft/base/fftpack/rffti/lib/rffti1.js are arguably better, so unless there is some justification for the current implementation, I'd say go ahead and align with the current status in the draft FFT PR.

kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/README.md
@kgryte
Apply suggestions from code review
daef1f3 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/docs/repl.txt
@kgryte
Apply suggestions from code review
5c8446b 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/rffti/test/test.js
t.strictEqual( rffti.length, 4, 'returns expected value' );
t.end();
});

Copy link
Copy Markdown
Member

@kgryte kgryte Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a test confirming that the workspace array is returned.

kgryte
kgryte requested changes Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the implementation file, this PR is looking good.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gunjjoshi @stdlib-bot @kgryte