Skip to content

bench: refactor to use string interpolation in @stdlib/strided/base (batch 1/2)#11449

Merged
kgryte merged 4 commits intostdlib-js:developfrom
udaykakade25:refactorStridedStringInterpolation
Apr 19, 2026
Merged

bench: refactor to use string interpolation in @stdlib/strided/base (batch 1/2)#11449
kgryte merged 4 commits intostdlib-js:developfrom
udaykakade25:refactorStridedStringInterpolation

Conversation

@udaykakade25
Copy link
Copy Markdown
Contributor

@udaykakade25 udaykakade25 commented Apr 14, 2026 •
edited by anandkaranubc
Loading

Progresses #8647
Progresses stdlib-js/metr-issue-tracker#410

Description

What is the purpose of this pull request?

This pull request:

  • refactors to use string interpolation in @stdlib/strided/base

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

As the task was simple, used Github Copilot's inline suggestion feature for this PR.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 14, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 14, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
strided/base/binary-dtype-signatures $\color{red}309/310$
$\color{green}+0.00%$ 		$\color{red}44/45$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{red}309/310$
$\color{green}+0.00%$
strided/base/dmap $\color{green}206/206$
$\color{green}+0.00%$ 		$\color{green}9/9$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}206/206$
$\color{green}+0.00%$
strided/base/dmap2 $\color{green}206/206$
$\color{green}+0.00%$ 		$\color{green}9/9$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}206/206$
$\color{green}+0.00%$
strided/base/dmskmap $\color{green}224/224$
$\color{green}+0.00%$ 		$\color{green}10/10$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}224/224$
$\color{green}+0.00%$
strided/base/dmskmap2 $\color{green}224/224$
$\color{green}+0.00%$ 		$\color{green}10/10$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}224/224$
$\color{green}+0.00%$
strided/base/dtype-resolve-enum $\color{red}96/97$
$\color{green}+0.00%$ 		$\color{red}7/8$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{red}96/97$
$\color{green}+0.00%$
strided/base/dtype-resolve-str $\color{red}95/96$
$\color{green}+0.00%$ 		$\color{red}7/8$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{red}95/96$
$\color{green}+0.00%$
strided/base/map-by $\color{green}551/551$
$\color{green}+0.00%$ 		$\color{green}36/36$
$\color{green}+0.00%$ 		$\color{green}6/6$
$\color{green}+0.00%$ 		$\color{green}551/551$
$\color{green}+0.00%$
strided/base/map-by2 $\color{green}608/608$
$\color{green}+0.00%$ 		$\color{green}42/42$
$\color{green}+0.00%$ 		$\color{green}6/6$
$\color{green}+0.00%$ 		$\color{green}608/608$
$\color{green}+0.00%$
strided/base/meta-data-props $\color{green}175/175$
$\color{green}+0.00%$ 		$\color{green}5/5$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}175/175$
$\color{green}+0.00%$
strided/base/mskunary-addon-dispatch $\color{green}480/480$
$\color{green}+0.00%$ 		$\color{green}65/65$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}480/480$
$\color{green}+0.00%$
strided/base/mskunary-dtype-signatures $\color{red}244/246$
$\color{green}+0.00%$ 		$\color{red}28/29$
$\color{green}+0.00%$ 		$\color{green}3/3$
$\color{green}+0.00%$ 		$\color{red}244/246$
$\color{green}+0.00%$
strided/base/mskunary-signature-callbacks $\color{red}217/220$
$\color{green}+0.00%$ 		$\color{red}19/20$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{red}217/220$
$\color{green}+0.00%$
strided/base/mskunary $\color{green}646/646$
$\color{green}+0.00%$ 		$\color{green}40/40$
$\color{green}+0.00%$ 		$\color{green}6/6$
$\color{green}+0.00%$ 		$\color{green}646/646$
$\color{green}+0.00%$
strided/base/nullary-addon-dispatch $\color{green}385/385$
$\color{green}+0.00%$ 		$\color{green}38/38$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}385/385$
$\color{green}+0.00%$
strided/base/nullary $\color{green}524/524$
$\color{green}+0.00%$ 		$\color{red}25/27$
$\color{green}+0.00%$ 		$\color{green}6/6$
$\color{green}+0.00%$ 		$\color{green}524/524$
$\color{green}+0.00%$
strided/base/quaternary $\color{green}257/257$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}257/257$
$\color{green}+0.00%$
strided/base/quinary $\color{green}269/269$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}269/269$
$\color{green}+0.00%$
strided/base/read-dataview $\color{green}413/413$
$\color{green}+0.00%$ 		$\color{green}24/24$
$\color{green}+0.00%$ 		$\color{green}5/5$
$\color{green}+0.00%$ 		$\color{green}413/413$
$\color{green}+0.00%$
strided/base/reinterpret-complex $\color{green}122/122$
$\color{green}+0.00%$ 		$\color{green}7/7$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}122/122$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@udaykakade25 udaykakade25 changed the title bench: refactor to use string interpolation in @stdlib/strided/base (batch 1/2) bench: refactor to use string interpolation in @stdlib/strided/base (batch 1/2) Apr 14, 2026
@anandkaranubc anandkaranubc self-requested a review April 19, 2026 04:59
@anandkaranubc
Copy link
Copy Markdown
Contributor

anandkaranubc commented Apr 19, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 19, 2026
@stdlib-bot stdlib-bot requested a review from a team April 19, 2026 05:01
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 19, 2026
@anandkaranubc
bench: preserve original benchmark name separators in strided/base
7cbbbaf 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
anandkaranubc
anandkaranubc approved these changes Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @udaykakade25 for working on this. The PR was in good shape, except it wasn’t preserving some of the original benchmark name separators. See my recent commit for reference.

Turns out GitHub Copilot’s inline suggestion feature wasn’t very careful about that. Let’s keep an eye on this so it doesn’t happen again.

@anandkaranubc anandkaranubc added Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. and removed Needs Review A pull request which needs code review. labels Apr 19, 2026
@anandkaranubc
Copy link
Copy Markdown
Contributor

anandkaranubc commented Apr 19, 2026

The benchmark CI failures are fixed here:

@anandkaranubc
Copy link
Copy Markdown
Contributor

anandkaranubc commented Apr 19, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 19, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 19, 2026
@kgryte kgryte merged commit f7304bd into stdlib-js:develop Apr 19, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

@anandkaranubc anandkaranubc anandkaranubc approved these changes

Assignees

No one assigned

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@udaykakade25 @stdlib-bot @anandkaranubc @kgryte