[6.x] Include missing time chars in DateFormat::containsTime#14555
Merged
jasonvarga merged 1 commit into6.xfrom Apr 27, 2026
Merged
[6.x] Include missing time chars in DateFormat::containsTime#14555jasonvarga merged 1 commit into6.xfrom
DateFormat::containsTime#14555jasonvarga merged 1 commit into6.xfrom
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
containsTimehelper was missing several PHP date format characters that represent time:a,A— am/pm markersB— Swatch internet timei— minutess— secondsu— microsecondsv— millisecondsIn practice this hasn't been a problem because hours (
G/g/H/h) are usually present alongside minutes/seconds, but formats likei:s,g:i a, or justawould have been incorrectly reported as not containing time.Spotted during review of #14552.