Skip to content

Add skill tracking + silent-run feedback for workflow_dispatch#778

Merged
rdimitrov merged 3 commits intomainfrom
workflow-dispatch-tracking-comments
Apr 22, 2026
Merged

Add skill tracking + silent-run feedback for workflow_dispatch#778
rdimitrov merged 3 commits intomainfrom
workflow-dispatch-tracking-comments

Conversation

@rdimitrov
Copy link
Copy Markdown
Member

@rdimitrov rdimitrov commented Apr 22, 2026

Three feedback-visibility improvements, all surfaced by the e2e test on PR #777.

1. Pre-skill placeholder comment (workflow_dispatch only)

`claude-code-action@v1` rejects `track_progress: true` on `workflow_dispatch` events with a hard error ("track_progress is only supported for events: pull_request, issue_comment, ..."). On manual retries and bootstrap dispatches, the PR gets no real-time "Claude is working" comment -- reviewers had to open the Actions tab to see whether the skill was actually running.

Posts a simple placeholder before `skill_gen`:

Claude Opus is generating docs updates for `toolhive` `v0.23.1`. Follow progress in the workflow run: [link]

Gated on `github.event_name == 'workflow_dispatch'` so Renovate-opened PRs keep the action's native tracking.

2. Post-augmentation summary comment (workflow_dispatch only)

Posts a summary table after the PR body has been augmented:

Step Conclusion
Generation (`skill_gen`) `success`
Editorial review (`skill_review`) `success`
Autofix (prettier/eslint) `success`
Skill commits produced `0`

Runs with `if: always()` so it fires even if an earlier step failed.

3. Silent-run [!NOTE] in the PR body (both triggers)

The e2e test on PR #777 ran to success but produced zero content commits -- because main was already ahead of the scratch branch's pinned version, so the skill correctly found nothing new to document. Problem: the PR body still read like a normal augmented PR with "content additions by upstream-release-docs" etc. Reviewers had no signal that nothing had actually been added.

New step (`skill_commits`) rev-counts commits between `pre_skill` SHA and HEAD. When the count is zero AND no `NO_CHANGES.md` was written, the "Augment PR body" step inserts a `[!NOTE]` block listing the three likely causes:

Note: The `upstream-release-docs` skill ran to success but produced no content commits on this PR. Likely causes:

  • The docs already cover this release (e.g. this PR was dispatched after an earlier PR for the same tag had merged, or `main` is already ahead of the pinned base).
  • The release genuinely had no doc-relevant changes but the skill did not write `NO_CHANGES.md` (which would have triggered the standard 'no changes' note above).
  • The skill's source verification concluded the existing prose already matches upstream behavior.

Only the version bump and any refreshed reference assets are included in this PR.

Applies to both `pull_request` and `workflow_dispatch` runs -- the silence problem isn't specific to the test path.

Validation

Once merged, dispatching the workflow against the e2e-test scratch branch a second time (or any silent release) should produce a PR that clearly says "no content added and here's why".

claude-code-action@v1 rejects track_progress: true on
workflow_dispatch events, so manual retries and bootstrap
dispatches leave no real-time signal on the PR that the skill is
running -- reviewers had to hunt through the Actions tab to see
progress. On pull_request runs the action posts its own tracking
comment, so this gap only affects workflow_dispatch.

Two workflow_dispatch-only comments:

- Before skill_gen: a "Claude Opus is generating docs updates for
  <project> <tag>. Follow progress: <run URL>" placeholder. Static
  but enough to signal "yes it started".

- After Augment PR body: a run summary with skill_gen /
  skill_review / autofix conclusions and a link to the run for
  the Claude Code Report. Runs even if earlier steps failed so
  reviewers can see which step died.

Both are gated on `github.event_name == 'workflow_dispatch'` to
avoid duplicating the action's own tracking on Renovate-opened PRs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 22, 2026 08:04
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-website Ready Ready Preview, Comment Apr 22, 2026 8:29am

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves reviewer visibility for manually triggered (workflow_dispatch) runs of the upstream-release-docs workflow by adding explicit PR timeline comments, compensating for claude-code-action@v1 not supporting track_progress on that event type.

Changes:

  • Post a “skill started” placeholder PR comment at the beginning of workflow_dispatch runs.
  • Post an “always()” completion summary PR comment at the end of workflow_dispatch runs with step conclusions and a run link.

Comment thread .github/workflows/upstream-release-docs.yml Outdated
Companion to the tracking comments: when the skill concludes
successfully but produces zero commits, the PR body previously
read as if content was added. Reviewers had no way to distinguish
"skill ran silently" from "skill produced stuff".

Adds:
  - A new step that rev-counts commits between pre_skill SHA and
    HEAD. Output exposed as steps.skill_commits.outputs.count.
  - A [!NOTE] block in the PR body when SKILL_COMMIT_COUNT=0 and
    no NO_CHANGES.md was written. Lists the three likely causes
    (docs already ahead of pin; no doc-relevant release; skill's
    verification matched existing prose).
  - A row in the workflow_dispatch summary comment showing the
    commit count.

Surfaced by the e2e test on PR #777: the skill ran to success but
produced nothing because main was already ahead of the pinned
scratch branch. PR body looked like a normal augmented PR.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@rdimitrov rdimitrov changed the title Add skill tracking comments for workflow_dispatch runs Add skill tracking + silent-run feedback for workflow_dispatch Apr 22, 2026
@rdimitrov rdimitrov requested a review from Copilot April 22, 2026 08:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves reviewer-facing feedback for the Upstream Release Docs GitHub Actions workflow, especially for workflow_dispatch runs where claude-code-action@v1 can’t use track_progress, and for “silent” successful runs that produce no content commits.

Changes:

  • Add a pre-skill placeholder PR comment for workflow_dispatch runs to surface that generation is in progress.
  • Add a post-run PR comment (always runs) summarizing step conclusions and the number of skill commits.
  • Detect “silent” runs (0 skill commits + no NO_CHANGES.md) and inject a [!NOTE] block into the PR body explaining likely causes.

Comment thread .github/workflows/upstream-release-docs.yml Outdated
Comment thread .github/workflows/upstream-release-docs.yml Outdated
Two fixes from Copilot's line-level comments:

1. Pre-skill placeholder comment step is best-effort. Was previously
   unguarded -- a transient gh failure (rate limit, API hiccup,
   permission edge case) would abort the workflow before skill_gen
   ran. Matches the `|| true` pattern already used by the post-run
   summary comment and the augmentation-failure comment.

2. Silent-run [!NOTE] is gated on BOTH skill steps having succeeded.
   The note claims "ran to success"; previously the condition only
   checked SKILL_COMMIT_COUNT=0 and NOTE_BLOCK empty, which could
   trigger the note even if skill_review had failed. Now requires
   steps.skill_gen.conclusion == 'success' AND
   steps.skill_review.conclusion == 'success'. Partial failures
   are already covered by the separate augmentation-failure
   comment step.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@rdimitrov rdimitrov merged commit 74b532c into main Apr 22, 2026
3 checks passed
@rdimitrov rdimitrov deleted the workflow-dispatch-tracking-comments branch April 22, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants