Skip to content

feat(boil): Relax vendor version constraint#1469

Merged
NickLarsenNZ merged 5 commits intomainfrom
feat/boil-allow-any-vendor-version
Apr 17, 2026
Merged

feat(boil): Relax vendor version constraint#1469
NickLarsenNZ merged 5 commits intomainfrom
feat/boil-allow-any-vendor-version

Conversation

@NickLarsenNZ
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ commented Apr 16, 2026

Previously we required the vendor version to be a valid semver (like we use for SDP releases: 26.3.0). This constraint has been relaxed to allow any valid container tag characters.

Also replaced semver crate with regex.

Example of misuse

❯ cargo boil some-chicken hadoop=3.4.2 --image-version .
error: invalid value '.' for '--image-version <IMAGE_VERSION>': invalid image tag characters for "."

This lets us correctly use the toolchain from rust-toolchain.toml, instead of hard setting to rustc (and co).
Previously we required the vendor version to be a valid semver (like we use for SDP releases: 26.3.0). This constraint has been relaxed to allow any valid container tag.

Replaced semver crate with regex.
@NickLarsenNZ NickLarsenNZ self-assigned this Apr 16, 2026
@NickLarsenNZ NickLarsenNZ moved this to Development: Waiting for Review in Stackable Engineering Apr 16, 2026
@NickLarsenNZ NickLarsenNZ requested a review from Techassi April 16, 2026 17:20
Comment thread rust/boil/src/cli/build.rs Outdated
Comment thread rust/boil/src/cli/build.rs Outdated
Comment thread rust/boil/src/cli/build.rs Outdated
Comment thread rust/boil/src/cli/build.rs Outdated
…e tag

We can't know how long the earlier part is at this point.

Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@NickLarsenNZ NickLarsenNZ force-pushed the feat/boil-allow-any-vendor-version branch from 175f0af to 9daee96 Compare April 16, 2026 17:56
Copy link
Copy Markdown
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Just two small comments.

Can we also note down the reason why we want to relax this in the PR description for which exact use-case we need this?

Comment thread rust/boil/src/cli/build.rs Outdated
Comment thread rust/boil/src/cmd/build.rs
Comment thread rust/boil/src/cmd/build.rs
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@NickLarsenNZ NickLarsenNZ enabled auto-merge April 17, 2026 07:12
@NickLarsenNZ NickLarsenNZ requested a review from Techassi April 17, 2026 07:14
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit 5ef2409 Apr 17, 2026
13 checks passed
@NickLarsenNZ NickLarsenNZ deleted the feat/boil-allow-any-vendor-version branch April 17, 2026 07:37
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants