Fix parameter handling in CAST expressions for duplicate params#4384
Merged
kyleconroy merged 1 commit intomainfrom Apr 17, 2026
Merged
Fix parameter handling in CAST expressions for duplicate params#4384kyleconroy merged 1 commit intomainfrom
kyleconroy merged 1 commit intomainfrom
Conversation
When a sqlc.arg() call was wrapped in a CAST (or MySQL's synthetic MATCH...AGAINST type cast), the resulting Parameter was not marked as named. Downstream struct-field generation then added numeric suffixes to disambiguate identical names, producing spurious fields like SearchTerm_3 alongside SearchTerm. Capture the isNamed result from FetchMerge so the column correctly reflects that it came from a named parameter, letting the code generator reuse a single struct field for repeated sqlc.arg(name) references. Fixes #4376
khepin
added a commit
to khepin/sqlc
that referenced
this pull request
Apr 18, 2026
…te-order-by-args * 'main' of https://github.com/sqlc-dev/sqlc: Map xid8 to pgtype.Uint64 for pgx/v5 (sqlc-dev#4387) Rename :one return variable when it conflicts with a parameter (sqlc-dev#4383) Coerce SQLite JSONB output regardless of type casing (sqlc-dev#4385) Dedupe sqlc.arg parameters wrapped in a type cast for MySQL (sqlc-dev#4384) Preserve MySQL optimizer hints in generated query text (sqlc-dev#4382) Skip CI/RTD builds when the change is irrelevant (sqlc-dev#4381) build(deps): bump the production-dependencies group across 1 directory with 11 updates (sqlc-dev#4380) build(deps): bump the production-dependencies group across 1 directory with 5 updates (sqlc-dev#4368) build(deps): bump pygments from 2.19.2 to 2.20.0 in /docs (sqlc-dev#4363) build(deps): bump requests from 2.32.5 to 2.33.0 in /docs (sqlc-dev#4357) Remove github.com/jackc/pgx/v4 dependency (sqlc-dev#4379) Upgrade Go toolchain to 1.26.2 (sqlc-dev#4378) build(deps): bump actions/upload-artifact from 6 to 7 (sqlc-dev#4320) docs: add sqlc-gen-sqlx to community language support (sqlc-dev#4371) build(deps): bump github.com/jackc/pgx/v5 from 5.8.0 to 5.9.0 (sqlc-dev#4377) Catch invalid ON CONFLICT DO UPDATE column references (sqlc-dev#4366)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes parameter handling in SQL queries that use CAST expressions with duplicate parameters. Previously, parameters used multiple times within CAST functions were not properly tracked as named parameters, causing incorrect code generation.
Fixes #4376
Key Changes
agecolumn to the test users table to support the new test caseAgefield to the User struct to reflect the schema changeSelectUserByAgeCasttest query that uses the same parameter twice within CAST expressionsresolveCatalogRefsininternal/compiler/resolve.goto properly track whether a parameter is named when resolving CAST type referencesisNamedreturn value fromparams.FetchMerge()col.IsNamedParam = isNamedto correctly mark parameters used in CAST expressionsImplementation Details
The fix ensures that when a parameter appears multiple times in a query (particularly within CAST expressions), the compiler correctly identifies it as a named parameter and generates the appropriate Go code. This prevents duplicate parameter passing and ensures proper parameter binding in the generated SQL execution code.
https://claude.ai/code/session_011tJhgjfWrTPw9yY4EpeJXG