Add thread_id to middlewares#755
Open
mateusz834 wants to merge 1 commit intodevelopfrom
Open
Conversation
mateusz834
force-pushed
the
dev/MP/thread-id-middlewares
branch
2 times, most recently
from
7259546 to
338f820
Compare
mateusz834
force-pushed
the
dev/MP/thread-id-middlewares
branch
from
338f820 to
0fd896e
Compare
Additionally make sure that subagents get an unique thread_id when no conversation store is being used. And enforce that thread_id cannot be an empty string, as that is clearly a bug.
mateusz834
force-pushed
the
dev/MP/thread-id-middlewares
branch
from
0fd896e to
29bea8d
Compare
szykol
reviewed
Apr 29, 2026
| ) | ||
|
|
||
| @pytest.mark.asyncio | ||
| @ai_snapshot_test() |
Collaborator
There was a problem hiding this comment.
does this test need to be snapshot?
szykol
reviewed
Apr 29, 2026
| def _convert_tool_request_from_lc( | ||
| request: LC_ToolCallRequest, model: BaseChatModel | ||
| ) -> ToolRequest: | ||
| assert isinstance(request.runtime.context, InvokeContext) |
Collaborator
There was a problem hiding this comment.
any particular reason why we assert that request.runtime.context is an InvokeContext when converting the tool request, but we don't when converting the model request (14 lines above this line)
szykol
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally make sure that subagents get an unique thread_id when no conversation store is being used.
And enforce that thread_id cannot be an empty string, as that is clearly a bug.