improvement(codebase): migrate tests to dbChainMock, extract react-query hooks

[waleedlatif1]

Summary

• migrate 97 test files to centralized dbChainMock/dbChainMockFns — remove hoisted chain-wiring boilerplate
• extend dbChainMock helper in @sim/testing to cover insert/update/delete/transaction/execute patterns
• extract useGitHubStars and useVoiceSettings react-query hooks from inline fetches
• centralize additional mocks (authMockFns, hybridAuthMockFns) and update sim-testing docs

Type of Change

• Improvement

Testing

Tested manually — full test suite (300 files, 5310 tests) passes; type-check and lint pass across all 8 packages

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 19, 2026 6:22pm

[cursor]

PR Summary

Medium Risk
Medium risk: changes API response shapes for chat auth/OTP flows and refactors chat client fetching to react-query, which could affect deployed chat UX if contracts diverge. Large-scale test mocking migration is broad but should be low runtime risk beyond test reliability.

Overview
Testing refactor: migrates a large set of Vitest suites to the centralized dbChainMock/dbChainMockFns (and related global mocks), removing per-file hoisted chain-wiring and many ad-hoc @sim/logger, @sim/db/schema, and auth/request utils mocks; adds/clarifies docs for the supported DB chains and resetDbChainMock() usage.

Runtime behavior changes: the chat auth endpoints now return full deployed chat config (id/title/description/customizations/authType/outputConfigs) on successful password/email OTP authentication, and the chat client is refactored to use new React Query hooks (useDeployedChatConfig, useChatPasswordAuth, useChatEmailOtp*, useGitHubStars, useVoiceSettings) instead of inline fetch/effects, including cache seeding after auth and a key={identifier} remount on route change.

^{Reviewed by Cursor Bugbot for commit 3220eea. Configure here.}

[greptile-apps]

Greptile Summary

This PR migrates 97 test files to the new centralized dbChainMock/dbChainMockFns helper (eliminating per-file vi.hoisted() chain boilerplate), adds centralized hybridAuthMock, and extracts useGitHubStars and useVoiceSettings from inline fetch calls into proper React Query hooks. Both previously reported critical issues with dbChainMock — the mismatched transaction instance and the missing execute on dbChainMock.db — have been fixed in the follow-up commit.

Confidence Score: 5/5

Safe to merge — all prior P0/P1 findings are resolved, remaining items are P2 style and docs suggestions

Both critical bugs flagged in prior threads (wrong transaction instance, missing db.execute) are confirmed fixed. Full test suite (5310 tests) passes. The remaining findings are: a docs wording inconsistency in sim-testing.md, a narrow from() mock gap for queries that skip .where() (documented intentional design, no failing tests), and a minor a11y note. None of these block merge.

packages/testing/src/mocks/database.mock.ts — the from() → terminal shortcut gap is worth noting for future contributors adding queries that skip .where()

Important Files Changed

Filename	Overview
packages/testing/src/mocks/database.mock.ts	Extends dbChainMock with insert/update/delete/transaction/execute chain support; prior thread bugs (missing execute, mismatched transaction instance) are fixed; from() still lacks direct terminals for queries that skip .where()
packages/testing/src/mocks/hybrid-auth.mock.ts	New centralized mock for @/lib/auth/hybrid; default implementation delegates to authMockFns.mockGetSession() so tests that only mock session auth continue to work transparently
apps/sim/hooks/queries/github-stars.ts	Extracts inline GitHub stars fetch into a proper React Query hook with 1-hour staleTime and string-typed initialData to eliminate undefined checks in consumers
apps/sim/hooks/queries/voice-settings.ts	Extracts voice settings fetch into a React Query hook; returns { sttAvailable: false } on error rather than throwing, keeping STT as a gracefully degraded optional capability
apps/sim/vitest.setup.ts	Adds hybridAuthMock to global vi.mock setup; databaseMock remains the global DB baseline and individual test files override with dbChainMock as needed
apps/sim/app/chat/[identifier]/chat.tsx	Replaces three inline fetch patterns with useDeployedChatConfig, useVoiceSettings, and useGitHubStars hooks; logic is otherwise unchanged
.claude/rules/sim-testing.md	Updated testing docs with dbChainMock/hybridAuthMock patterns; "Global Mocks" section slightly contradicts the database chain override guidance
packages/testing/src/mocks/index.ts	Adds exports for dbChainMock, dbChainMockFns, resetDbChainMock, hybridAuthMock, hybridAuthMockFns to the package's public surface

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph dbChainMock["dbChainMock (centralized)"]
        select["select / selectDistinct / selectDistinctOn"]
        from["from()"]
        joins["innerJoin / leftJoin"]
        where["where()"]
        terminals["limit / orderBy / returning / groupBy"]
        insert["insert()"]
        values["values()"]
        ins_returns["returning / onConflictDoUpdate / onConflictDoNothing"]
        update["update()"]
        set["set()"]
        del["delete()"]
        execute["execute()"]
        transaction["transaction(cb)"]
    end

    select --> from
    from --> joins --> where
    from --> where
    where --> terminals

    insert --> values --> ins_returns

    update --> set --> where
    del --> where

    execute -.->|"resolves []"| done(["Promise.resolve([])"])
    transaction -.->|"calls cb(dbChainMock.db)"| dbChainMock

    subgraph hooks["New React Query Hooks"]
        gh["useGitHubStars\n(staleTime: 1h, initialData: '27.8k')"]
        vs["useVoiceSettings\n(staleTime: 5m, returns sttAvailable:false on error)"]
    end

    gh -->|"/api/stars"| server["Server"]
    vs -->|"/api/settings/voice"| server

Loading

_{Reviews (5): Last reviewed commit: "fix(chat): reset chat state on identifie..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 3220eea. Configure here.}