Improve assembly block handling to prevent item duplication#632
Open
SAILQAQ wants to merge 1 commit intoryanhcode:mainfrom
Open
Improve assembly block handling to prevent item duplication#632SAILQAQ wants to merge 1 commit intoryanhcode:mainfrom
SAILQAQ wants to merge 1 commit intoryanhcode:mainfrom
Conversation
Two fixes combined: 1. From pr-365: Replace old blocks with barriers before removal. This prevents brittle blocks (torches, buttons, etc.) from breaking when their supportblock is removed, which could also cause duplication. 2. New fix: After saving BE NBT, call level.removeBlockEntity() to detach the block entity from the world before it can drop items. Then destroy barriers via level.setBlock() with UPDATE_MOVE_BY_PISTON | UPDATE_SUPPRESS_DROPS | UPDATE_CLIENTS — the same approach Create uses in its contraption system.
|
|
SAILQAQ
changed the title
Author
|
This should fix the duplication issues for most modded containers (those that don't implement Clearable) and attachable blocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes combined:
From Fix for #48 (items duping upon assembly/disassembly) #365: Replace old blocks with barriers before removal. This prevents brittle blocks (torches, buttons, etc.) from breaking when their supportblock is removed, which could also cause duplication.
New fix: After saving BE NBT, call level.removeBlockEntity() to detach the block entity from the world before it can drop items. Then destroy barriers via level.setBlock() with UPDATE_MOVE_BY_PISTON | UPDATE_SUPPRESS_DROPS | UPDATE_CLIENTS — the same approach Create uses in its contraption system.