test(s3): cover Aliyun bucket lookup fallbacks#152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
None. This is automation-driven test gap coverage for the recent Aliyun OSS bucket lookup change.
Background
PR #151 changed the S3 client so
bucket_lookup = autokeeps path-style addressing for most S3-compatible endpoints, but switches to virtual-hosted style for Aliyun OSS service endpoints. The merged change covered the main Aliyun and custom-endpoint paths, but a few fallback branches remained untested.Solution
Add focused
rc-s3unit coverage for the new bucket lookup helper:aliyuncs.comservices keep path-style addressing.bucket_lookupvalues keep the conservative path-style fallback.Test status
cargo test -p rc-s3 bucket_lookup --libmake pre-commit