test(cli): cover noun-first list aliases#115
Merged
Conversation
dbc6ddf to
2761308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds focused parser coverage for the noun-first ls aliases introduced with the recent bucket/object command groups.
Problem
The command-group work in #76 added bucket and object entrypoints with ls as an alias for list, but the parser tests in crates/cli/src/commands/mod.rs did not assert those alias routes. That left a small regression window where the alias wiring could drift without a fast unit test catching it.
Root cause
Existing parser coverage around the noun-first surface focused on bucket cors and other follow-up gaps, but not on the ls aliases attached directly to BucketCommands::List and ObjectCommands::List.
Fix
The patch keeps scope tight to crates/cli/src/commands/mod.rs:
Both assertions verify clap dispatch reaches the expected noun-first command variants and preserves the parsed path.
Validation
I ran:
I also ran make pre-commit per the automation instructions, but this checkout does not define that target:
text
make: *** No rule to make target pre-commit'. Stop.