Open
Conversation
This uses String#dump to print out control characters legibly, whic makes the CRLF line endings explicit and enables reliable copy/pasting of logged data for tests or debugging. This also improves how sent/rcvd data is interleaved (in my opinion). Note that, because client-sent data is generally in the main/application thread(s) (inside `#synchronize`), and server responses are received in the server thread (_not_ synchronized), this did have a threading race condition. So this updated version uses `synchronize` to log the server responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses String#dump to print out control characters legibly, which makes the CRLF line endings explicit and enables reliable copy/pasting of logged data for tests or debugging.
This also improves how sent/rcvd data is interleaved (in my opinion).
Note that, because client-sent data is generally in the main/application thread(s) (inside
#synchronize), and server responses are received in the server thread (not synchronized), this did have a threading race condition. So this updated version usessynchronizeto log the server responses.