fix(eslint): align language option defaults#131
Merged
chenjiahan merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the React ESLint templates by relying on ESLint’s default language option values and keeping the generated configs closer to the recommended baselines.
Changes:
- Remove explicit
ecmaVersionconfiguration from the React TS and React JS ESLint templates. - Remove explicit
parserOptions.ecmaVersion/parserOptions.sourceTypefrom the React JS template. - Drop the React JS-only
no-unused-varsoverride to better match@eslint/jsrecommended defaults.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| template-eslint/react-ts/eslint.config.mjs | Removes redundant ecmaVersion so the template relies on ESLint defaults. |
| template-eslint/react-js/eslint.config.mjs | Removes redundant language/parser options and a custom no-unused-vars override to align with recommended defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ecmaVersionandsourceTypesettings that already default to"latest"and"module".no-unused-varsoverride from the React JS template so the generated config stays closer to the baseline recommended config.Related Links