Skip to content

fix(eslint): align language option defaults#131

Merged
chenjiahan merged 1 commit intomainfrom
chenjiahan/chore-eslint-default-language-options
Apr 23, 2026
Merged

fix(eslint): align language option defaults#131
chenjiahan merged 1 commit intomainfrom
chenjiahan/chore-eslint-default-language-options

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Apr 23, 2026

Summary

  • Align the React ESLint templates with ESLint's recommended language option defaults by removing explicit ecmaVersion and sourceType settings that already default to "latest" and "module".
  • Drop the extra no-unused-vars override from the React JS template so the generated config stays closer to the baseline recommended config.

Related Links

@chenjiahan chenjiahan changed the title chore(eslint): align language option defaults fix(eslint): align language option defaults Apr 23, 2026
@chenjiahan chenjiahan marked this pull request as ready for review April 23, 2026 02:55
Copilot AI review requested due to automatic review settings April 23, 2026 02:55
@chenjiahan chenjiahan merged commit 61309e6 into main Apr 23, 2026
6 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/chore-eslint-default-language-options branch April 23, 2026 02:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the React ESLint templates by relying on ESLint’s default language option values and keeping the generated configs closer to the recommended baselines.

Changes:

  • Remove explicit ecmaVersion configuration from the React TS and React JS ESLint templates.
  • Remove explicit parserOptions.ecmaVersion / parserOptions.sourceType from the React JS template.
  • Drop the React JS-only no-unused-vars override to better match @eslint/js recommended defaults.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
template-eslint/react-ts/eslint.config.mjs Removes redundant ecmaVersion so the template relies on ESLint defaults.
template-eslint/react-js/eslint.config.mjs Removes redundant language/parser options and a custom no-unused-vars override to align with recommended defaults.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants