Skip to content

chore: simplify template package names #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Apr 14, 2026
Merged

chore: simplify template package names #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion template-biome/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-biome",
"name": "biome",
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion template-eslint/react-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-react-js",
"name": "eslint-react-js",
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion template-eslint/react-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-react-ts",
"name": "eslint-react-ts",
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion template-eslint/svelte-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-svelte-js",
"name": "eslint-svelte-js",
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion template-eslint/svelte-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-svelte-ts",
"name": "eslint-svelte-ts",
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion template-eslint/vanilla-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-common-js",
"name": "eslint-common-js",
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint template variant folder is vanilla-js (and the code refers to the variant name vanilla-js), but this package.json name uses eslint-common-js. For consistency with the other variants (eslint-react-js, eslint-svelte-js, etc.) and with the variant identifier, consider renaming this to eslint-vanilla-js (or otherwise aligning the naming scheme across variants).

Suggested change
"name": "eslint-common-js",
"name": "eslint-vanilla-js",

Copilot uses AI. Check for mistakes.
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion template-eslint/vanilla-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-common-ts",
"name": "eslint-common-ts",
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint template variant folder is vanilla-ts (and the code refers to the variant name vanilla-ts), but this package.json name uses eslint-common-ts. For consistency with the other variants (eslint-react-ts, eslint-vue-ts, etc.) and with the variant identifier, consider renaming this to eslint-vanilla-ts (or otherwise aligning the naming scheme across variants).

Suggested change
"name": "eslint-common-ts",
"name": "eslint-vanilla-ts",

Copilot uses AI. Check for mistakes.
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion template-eslint/vue-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-vue-js",
"name": "eslint-vue-js",
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion template-eslint/vue-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-vue-ts",
"name": "eslint-vue-ts",
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion template-prettier/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "rsbuild-prettier",
"name": "prettier",
"private": true,
"version": "1.0.0",
"scripts": {
Expand Down
Loading