Remove isRepo negative-test exception and use aliases in test array#247
Open
Remove isRepo negative-test exception and use aliases in test array#247
Conversation
Agent-Logs-Url: https://github.com/refined-github/github-url-detection/sessions/39c59fa2-5d47-4a9a-9e3a-b15a0792b4bd Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
fregante
April 15, 2026 18:14
View session
fregante
approved these changes
Apr 15, 2026
| 'isRepositoryActions', | ||
| 'isSingleCommit', | ||
| 'isSingleReleaseOrTag', | ||
| 'isTags', |
Member
There was a problem hiding this comment.
Holy cow that's a lot 😂 but better than repeating all the URLs.
Not sure if it's worth removing the exception… but having no exceptions is always better.
fregante
reviewed
Apr 15, 2026
| 'isRepoSearch', | ||
| 'isRepoSettings', // Includes isRepoMainSettings | ||
| 'isRepoTaxonomyIssueOrPRList', | ||
| 'isRepoWiki', // Includes isNewWikiPage, isEditingWikiPage, isCompareWikiPage |
Member
There was a problem hiding this comment.
These comments are not required and they don't have to be kept up to date, but it's good to have them as a sanity check in the future.
LLMs are good at keeping these lists up to date anyway.
Member
|
@copilot fix the lint step too. Run |
Agent-Logs-Url: https://github.com/refined-github/github-url-detection/sessions/f3ee306a-f64c-4b9c-853a-b58305284358 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isRepotest array inindex.tswith comprehensive aliases for all subset detectionsisReponegative-test exception inindex.test.ts(lines 57-59)isReposubsets visually (see below)xo --fix)isReposubset graphgraph TD isRepo --> isRepoGitObject isRepoGitObject --> isRepoTree isRepoGitObject --> isSingleFile isRepoGitObject --> isBlame isRepoTree --> isRepoRoot isRepoRoot --> isRepoHome isSingleFile --> isRenderedTextFile isRepo --> isSingleCommit isRepo --> isRepoCommitList isRepo --> isCompare isCompare --> isQuickPR isRepo --> isIssue isRepo --> isNewIssue isRepo --> isLabelList isRepo --> isMilestone isRepo --> isMilestoneList isRepo --> isNewFile isRepo --> isNewRelease isRepo --> isPR isPR --> isPRConversation isPR --> isPRFiles isPR --> isPRCommitList isPRFiles --> isPRCommit isRepo --> isPRConflicts isRepo --> isReleases isRepo --> isTags isRepo --> isSingleReleaseOrTag isRepo --> isDeletingFile isRepo --> isEditingFile isRepo --> isEditingRelease isRepo --> isRepoWiki isRepoWiki --> isNewWikiPage isRepoWiki --> isEditingWikiPage isRepoWiki --> isCompareWikiPage isRepo --> isRepoPRList isRepo --> isRepoIssueList isRepo --> isRepoTaxonomyIssueOrPRList isRepo --> isProjects isRepo --> isRepoSearch isRepo --> isRepoSettings isRepoSettings --> isRepoMainSettings isRepo --> isFileFinder isRepo --> isRepoForksList isRepo --> isRepoNetworkGraph isRepo --> isForkingRepo isRepo --> isBranches isRepo --> isActionRun isActionRun --> isActionJobRun isRepo --> isNewAction isRepo --> isRepositoryActions