fix(olm-deploy): Use subscription name compatible with what tests expect

[olivergondza]

The new name is explicitly expected by some tests

gitops-operator/test/openshift/e2e/ginkgo/fixture/fixture.go

Line 429 in 71974fd

sub := &olmv1alpha1.Subscription{ObjectMeta: metav1.ObjectMeta{Name: "openshift-gitops-operator", Namespace: "openshift-gitops-operator"}}

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

• [n/a] Documentation update is required by this PR.
• [n/a] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

• [n/a] Unit Test
• [n/a] E2E Test

How to test changes / Special notes to the reviewer:

./bin/ginkgo -v -focus 'should create argocd agent principal resources, and pod should start successfully with default image' -r ./test/openshift/e2e/ginkgo/sequential/

@jgwest, PTAL

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jgwest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olivergondza]

olm-deploy is not covered by unit tests. Test failures are unrelated.

[jgwest]

Cluster init flake
/retest

[jgwest]

LGTM, thanks @olivergondza!