docs: correct inaccurate infinite loop claim in set-state-in-render#8412
Open
Assamee wants to merge 1 commit intoreactjs:mainfrom
Open
docs: correct inaccurate infinite loop claim in set-state-in-render#8412Assamee wants to merge 1 commit intoreactjs:mainfrom
Assamee wants to merge 1 commit intoreactjs:mainfrom
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8411
Summary
The current documentation for the
set-state-in-renderlint rule states that a specific condition (e.g.count < max) will trigger an infinite loop. While this is an anti-pattern that causes unnecessary re-renders, the claim of an "infinite loop" is inaccurate in this specific code example.In the provided snippet, the component stabilises once the state update condition becomes false. I have updated the wording to clarify that the core issue is the violation of render purity, rather than a guaranteed infinite loop.
Testing and Verification
I replicated the documentation's example in a local Vite/React environment to verify the actual behaviour:
countat0with amaxof5.countreached5, the conditioncount < maxevaluated tofalse, and the component successfully settled.