fix(theme-provider): callback deps, inline script, and onThemeChange#760
Draft
paanSinghCoder wants to merge 1 commit intomainfrom
Draft
fix(theme-provider): callback deps, inline script, and onThemeChange#760paanSinghCoder wants to merge 1 commit intomainfrom
paanSinghCoder wants to merge 1 commit intomainfrom
Conversation
…646) - Correct setTheme deps to track storageKey instead of unused forcedTheme. - Add missing enableSystem and applyTheme to handleMediaQuery deps. - Fix inline-script generation in updateDOM: drop the `name + "|| ''"` concat that produced classList.add('') (throws) or setAttribute(n, '') (junk attribute) when a value-map lookup missed; guard the literal path with if(${val}) so the DOM call only runs when the lookup is truthy. - Add onThemeChange prop. Fires on actual theme/resolvedTheme changes, skipping the initial mount. Uses a ref so the callback identity is read at fire time, decoupling effect cadence from consumer render churn. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses items 2, 3, and 5 from #646.
setThemenow tracksstorageKey(wasforcedTheme, unused).handleMediaQuerynow includesenableSystemandapplyTheme. Both fix latent stale-closure bugs that surface only when those props change at runtime.updateDOMno longer emitsc.add(x[e]|| ''). The literal path is gated withif(${val})so a missingvalue-map entry doesn't reachclassList.add('')(throws) orsetAttribute(n, '')(junk attr).onThemeChangecallback — fires on actualtheme/resolvedThemechanges, skips initial mount. Held via ref so consumer render churn doesn't over-fire and the callback never goes stale.Type of Change
How Has This Been Tested?
Manual repro on
mainvs branch for each fix. Tests TODO — leaving as draft untiltheme-provider.test.tsxis extended.Related Issues
Refs #646 (items 2, 3, 5).
🤖 Generated with Claude Code