Skip to content

Add regression tests for previously-failing CoreML lowerings#19248

Open
john-rocky wants to merge 2 commits intopytorch:mainfrom
john-rocky:coreml/regression-tests
Open

Add regression tests for previously-failing CoreML lowerings#19248
john-rocky wants to merge 2 commits intopytorch:mainfrom
john-rocky:coreml/regression-tests

Conversation

@john-rocky
Copy link
Copy Markdown

Summary

Six bugs filed against the CoreML partitioner / backend in mid-2025 no
longer reproduce on the current toolchain (executorch main + coremltools 9.0):

I verified each repro on macOS 15 / Python 3.10 / coremltools 9.0 and they
now lower cleanly. This PR adds them to test_coreml_partitioner.py so
the wins are pinned in CI, and any future change that regresses one of
them surfaces immediately.

Test plan

$ python -m unittest -v executorch.backends.apple.coreml.test.test_coreml_partitioner.TestCoreMLPartitioner.test_previously_failing_ops_lower_successfully
Ran 1 test in 2.677s

OK

The test is a single method with one self.subTest(name=...) per issue so a
re-regression of any one case is reported individually. I'm happy to follow
up with separate "closes" comments / closes on the issues themselves once
this lands.

Authored with Claude.

These models were filed as crashes against the CoreML partitioner /
backend in mid-2025 (pytorch#11688, pytorch#11691, pytorch#11701, pytorch#11702, pytorch#11708, pytorch#11709).
All six lower successfully on the current toolchain (executorch main
+ coremltools 9.0); add them to the partitioner test suite so any
future regression that re-breaks one of them is caught in CI.
@john-rocky john-rocky requested a review from shoumikhin as a code owner May 1, 2026 04:54
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19248

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 12 Awaiting Approval

As of commit 0f27740 with merge base 94d2881 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 1, 2026

Hi @john-rocky!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@john-rocky john-rocky force-pushed the coreml/regression-tests branch from 6d191fa to 31f0692 Compare May 1, 2026 05:00
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants