make quantized_max_pool2d_nhwc handle case of C>64 (#19238)#19238
Open
wl1026sun wants to merge 1 commit intopytorch:mainfrom
Open
make quantized_max_pool2d_nhwc handle case of C>64 (#19238)#19238wl1026sun wants to merge 1 commit intopytorch:mainfrom
wl1026sun wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19238
Note: Links to docs will display an error until the docs builds have been completed.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@wl1026sun has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103096179. |
This PR needs a
|
wl1026sun
force-pushed
the
export-D103096179
branch
from
b90b2ec to
835e67c
Compare
meta-codesync
Bot
changed the title
wl1026sun
added a commit
to wl1026sun/executorch
that referenced
this pull request
May 1, 2026
Summary: now the TIE quantized_max_pool2d_nhwc general path processes channels in chunks of 16 groups (64 bytes) at a time using a fixed stack array with an outer loop. This supports arbitrary C (any multiple of 4). Also adds test cases for C=128, C=256, k=3x3, and padding to cover all TIE kernel dispatch paths. Reviewed By: khazaei Differential Revision: D103096179
wl1026sun
force-pushed
the
export-D103096179
branch
from
835e67c to
1c24640
Compare
wl1026sun
added a commit
to wl1026sun/executorch
that referenced
this pull request
May 1, 2026
Summary: now the TIE quantized_max_pool2d_nhwc general path processes channels in chunks of 16 groups (64 bytes) at a time using a fixed stack array with an outer loop. This supports arbitrary C (any multiple of 4). Also adds test cases for C=128, C=256, k=3x3, and padding to cover all TIE kernel dispatch paths. Reviewed By: khazaei Differential Revision: D103096179
wl1026sun
force-pushed
the
export-D103096179
branch
from
1c24640 to
eb3a4de
Compare
meta-codesync
Bot
changed the title
wl1026sun
force-pushed
the
export-D103096179
branch
from
eb3a4de to
4eaa763
Compare
Summary: now the TIE quantized_max_pool2d_nhwc general path processes channels in chunks of 16 groups (64 bytes) at a time using a fixed stack array with an outer loop. This supports arbitrary C (any multiple of 4). Also adds test cases for C=128, C=256, k=3x3, and padding to cover all TIE kernel dispatch paths. Reviewed By: khazaei Differential Revision: D103096179
meta-codesync
Bot
changed the title
wl1026sun
added a commit
to wl1026sun/executorch
that referenced
this pull request
May 1, 2026
Summary: now the TIE quantized_max_pool2d_nhwc general path processes channels in chunks of 16 groups (64 bytes) at a time using a fixed stack array with an outer loop. This supports arbitrary C (any multiple of 4). Also adds test cases for C=128, C=256, k=3x3, and padding to cover all TIE kernel dispatch paths. Reviewed By: khazaei Differential Revision: D103096179
wl1026sun
force-pushed
the
export-D103096179
branch
2 times, most recently
from
331e086 to
cf61c03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
now the TIE quantized_max_pool2d_nhwc general path processes channels in chunks of 16 groups (64 bytes) at a time using a fixed stack array with an outer loop. This supports arbitrary C (any multiple of 4).
Also adds test cases for C=128, C=256, k=3x3, and padding to cover all TIE kernel dispatch paths.
Reviewed By: khazaei
Differential Revision: D103096179