Add explicit matplotlib dep for parakeet and sortformer#19231
Open
rascani wants to merge 2 commits intopytorch:mainfrom
Open
Add explicit matplotlib dep for parakeet and sortformer#19231rascani wants to merge 2 commits intopytorch:mainfrom
rascani wants to merge 2 commits intopytorch:mainfrom
Conversation
The Metal, MLX, and CUDA Windows export workflows started failing on 2026-04-30 with `ModuleNotFoundError: No module named 'matplotlib'` when the parakeet/sortformer export scripts import `nemo.collections.asr`. NeMo's clustering_diarizer module top-level imports matplotlib via vad_utils, but matplotlib is not declared by `nemo_toolkit[asr]`. A release in some transitive dep stopped pulling matplotlib in incidentally. nemo_toolkit itself was unchanged (2.7.3 since 2026-04-23), so adding matplotlib explicitly is the targeted fix. Authored with Claude Code.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19231
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated FailuresAs of commit 63fc0fa with merge base f3e49ff ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
Gasoonjia
added
ciflow/metal
ciflow/cuda
module: mlx
Adding matplotlib as an explicit line in install_requirements.txt changed pip's resolver behavior: with matplotlib pinned first the resolver lands on nemo_toolkit-2.0.0 in the sortformer CUDA job, which predates SortformerEncLabelModel and produces `ImportError: cannot import name 'SortformerEncLabelModel' from 'nemo.collections.asr.models'`. The successful 12:51 UTC run on main resolved nemo_toolkit-2.7.3 transitively, with matplotlib coming along for the ride. Pin both directly so the install order can no longer perturb the resolution. Authored with Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Metal, MLX, and CUDA Windows export workflows started failing on 2026-04-30 with
ModuleNotFoundError: No module named 'matplotlib'when the parakeet/sortformer export scripts importnemo.collections.asr. NeMo's clustering_diarizer module top-level imports matplotlib via vad_utils, but matplotlib is not declared bynemo_toolkit[asr]. A release in some transitive dep stopped pulling matplotlib in incidentally. nemo_toolkit itself was unchanged (2.7.3 since 2026-04-23), so adding matplotlib explicitly is the targeted fix.Authored with Claude Code.
Test plan
CI
cc @metascroy