Skip to content

gh-148967: Fix FFI type pointer handling for C complex support in set_stginfo_ffi_type_pointer#148969

Merged
encukou merged 2 commits intopython:mainfrom
sunmy2019:gh-148967
May 1, 2026
Merged

gh-148967: Fix FFI type pointer handling for C complex support in set_stginfo_ffi_type_pointer#148969
encukou merged 2 commits intopython:mainfrom
sunmy2019:gh-148967

Conversation

@sunmy2019
Copy link
Copy Markdown
Member

@sunmy2019 sunmy2019 commented Apr 24, 2026 •
edited
Loading

The else branch is taken from the earlier _ctype.c.

@bedevere-app bedevere-app Bot mentioned this pull request Apr 24, 2026
Closed
@sunmy2019 sunmy2019 requested review from encukou and skirpichev April 24, 2026 17:55
@sunmy2019
Copy link
Copy Markdown
Member Author

sunmy2019 commented Apr 24, 2026

I don't think we need to add NEWs. The regression is just introduced by 769cc83.

@sunmy2019 sunmy2019 added 3.14 bugs and security fixes needs backport to 3.14 bugs and security fixes 3.15 new features, bugs and security fixes skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 24, 2026
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 24, 2026

🤖 New build scheduled with the buildbot fleet by @sunmy2019 for commit 6d85124 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F148969%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 24, 2026
@sunmy2019 sunmy2019 removed 3.14 bugs and security fixes 3.15 new features, bugs and security fixes labels Apr 24, 2026
skirpichev
skirpichev approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

skirpichev
skirpichev reviewed Apr 25, 2026
View reviewed changes
Comment thread Modules/_ctypes/_ctypes.c
@encukou encukou merged commit f2c7c0d into python:main May 1, 2026
142 of 143 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 1, 2026

Thanks @sunmy2019 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 1, 2026

GH-149224 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 1, 2026
encukou pushed a commit that referenced this pull request May 1, 2026
@miss-islington @sunmy2019
[3.14] gh-148967: Fix FFI type pointer handling for C complex support…
5ec845a 
… in set_stginfo_ffi_type_pointer (GH-148969) (GH-149224)

(cherry picked from commit f2c7c0d)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes

@encukou encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sunmy2019 @bedevere-bot @skirpichev @encukou