Open
Conversation
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
5 tasks
eendebakpt
reviewed
Apr 22, 2026
eendebakpt
reviewed
Apr 22, 2026
eendebakpt
reviewed
Apr 22, 2026
Comment on lines
+39
to
+44
| PyObject *r = PyFunction_GetModule(PyStackRef_AsPyObjectBorrow(f->f_funcobj)); | ||
| if (!r) { | ||
| PyErr_Clear(); | ||
| Py_RETURN_NONE; | ||
| } | ||
| return Py_NewRef(r); |
Member
There was a problem hiding this comment.
I don't think PyFunction_GetModule can fail here, because f_funcobj shouldn't ever be anything other than a function object. We can use _PyFrame_GetFunction to assert this:
Suggested change
| PyObject *r = PyFunction_GetModule(PyStackRef_AsPyObjectBorrow(f->f_funcobj)); | |
| if (!r) { | |
| PyErr_Clear(); | |
| Py_RETURN_NONE; | |
| } | |
| return Py_NewRef(r); | |
| PyObject *r = PyFunction_GetModule(_PyFrame_GetFunction(f)); | |
| if (!r) { | |
| Py_RETURN_NONE; | |
| } | |
| return Py_NewRef(r); |
Member
Author
There was a problem hiding this comment.
hm, do we even need the null check for funcobj on the line above? Not sure it can ever be NULL.
Member
Author
There was a problem hiding this comment.
I'll keep that for paranoia. Also keeping an assertion that it really is a PyFunctionObject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces JelleZijlstra#4. See python/steering-council#258.
📚 Documentation preview 📚: https://cpython-previews--148831.org.readthedocs.build/