gh-148464: Add missing __ctype_le/be__ attributes for complex types in the ctype module#148485
gh-148464: Add missing __ctype_le/be__ attributes for complex types in the ctype module#148485encukou merged 13 commits intopython:mainfrom
__ctype_le/be__ attributes for complex types in the ctype module#148485Conversation
…ex types in the ctype module
skirpichev
force-pushed
the
add-F/D_sw/148464
branch
from
226aaab to
1e45180
Compare
| D_get_sw(void *ptr, Py_ssize_t size) | ||
| { | ||
| assert(NUM_BITS(size) || (size == 2*sizeof(double))); | ||
| return PyComplex_FromDoubles(PyFloat_Unpack8(ptr, PY_BIG_ENDIAN), |
There was a problem hiding this comment.
Could you add error handling for the unpacks here and PyFloat_Unpack4 below?
if (x == -1.0 && PyErr_Occurred()) {
I'd be happier if ctypes didn't rely on an undocumented implementation detail here.
There was a problem hiding this comment.
Why undocumented? It's documented and widely used across the CPython codebase, e.g. in same file.
There was a problem hiding this comment.
widely used
Well, that's a little lie. But it indeed was used in this way in the ctypes and some other places. Until v3.15.0a8 that was a bug.
It probably not worth to change other places, where error checks kept. But I don't see good reasons to not rely on documented behavior for new code.
There was a problem hiding this comment.
Ah, I missed the docs note!
I still think it's better to be defensive/portable in ctypes.
There was a problem hiding this comment.
I would prefer rather be consistent across the module (or even for the one file!). Hardly there is a chance that this code will be used outside of the CPython.
There was a problem hiding this comment.
OK, I'll leave it to another PR.
Old code relying on implementation detail, that elements[1] for the FFI_TYPE_COMPLEX was never read. But this type actually shares same assumption as the FFI_TYPE_STRUCT: the elements field is a NULL-terminated array of pointers to ffi_type objects. So far for primitive types - only complex types have this struct field as non-NULL (two element array).
|
BTW, the |
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
|
Thanks @skirpichev for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thank you! |
…ex types in the ctype module (pythonGH-148485) (cherry picked from commit 769cc8338f35eb134508aca701a59342bcb6a84b) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
|
GH-148677 is a backport of this pull request to the 3.14 branch. |
5 participants
__ctype_{be,le}__attributes missing forctypes.c_*_complextypes #148464