test(unit): mark PyPI-backed tests as network#1093
test(unit): mark PyPI-backed tests as network#1093mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo existing dependency-resolution tests in the test suite are decorated with Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
These tests are already running and passing with network access in CI. They aren't failing today. It also passes local dev environments which has internet access. Without @pytest.mark.network, the tests silently make network calls they pass if you have internet, but they're slower and would fail in an air-gapped environment. |
|
@mergify rebase |
These tests install build requirements from https://pypi.org/simple via uv, so they require real network access and should be skipped unless --with-network is enabled. Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
|
Deprecation notice: This pull request comes from a fork and was rebased using |
✅ Branch has been successfully rebased |
6763404 to
8f91793
Compare
Pull Request Description
What
Mark PyPI-backed tests as network.
Why
These tests install build requirements from https://pypi.org/simple via
uv, so they require real network access and should be skipped unless
--with-network is enabled.