Skip to content

test(unit): mark PyPI-backed tests as network#1093

Merged
mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
booxter:mark-tests-network
Apr 27, 2026
Merged

test(unit): mark PyPI-backed tests as network#1093
mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
booxter:mark-tests-network

Conversation

@booxter
Copy link
Copy Markdown
Contributor

@booxter booxter commented Apr 26, 2026

Pull Request Description

What

Mark PyPI-backed tests as network.

Why

These tests install build requirements from https://pypi.org/simple via
uv, so they require real network access and should be skipped unless
--with-network is enabled.

@booxter booxter requested a review from a team as a code owner April 26, 2026 21:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 46ed8f1c-2d31-4403-9c53-b9f3b27319ed

📥 Commits

Reviewing files that changed from the base of the PR and between 6763404 and 8f91793.

📒 Files selected for processing (1)
  • tests/test_dependencies.py

📝 Walkthrough

Walkthrough

Two existing dependency-resolution tests in the test suite are decorated with @pytest.mark.network to mark them as network-dependent tests. This allows pytest to classify and optionally exclude these tests from certain test runs. No test logic, assertions, or public entity declarations are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: marking PyPI-backed tests with the network marker to control their execution.
Description check ✅ Passed The description clearly explains what was changed (marking tests as network) and why (they require real network access to PyPI and should be skipped by default).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot added the ci label Apr 26, 2026
@LalatenduMohanty
Copy link
Copy Markdown
Member

These tests are already running and passing with network access in CI. They aren't failing today. It also passes local dev environments which has internet access.

Without @pytest.mark.network, the tests silently make network calls they pass if you have internet, but they're slower and would fail in an air-gapped environment.
With the marker, they're skipped by default and only run when you explicitly opt in

@LalatenduMohanty
Copy link
Copy Markdown
Member

@mergify rebase

These tests install build requirements from https://pypi.org/simple via
uv, so they require real network access and should be skipped unless
--with-network is enabled.

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 27, 2026

Deprecation notice: This pull request comes from a fork and was rebased using bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the rebase action will no longer be able to rebase fork pull requests with this configuration. Please switch to the update action/command to ensure compatibility going forward.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 27, 2026

rebase

✅ Branch has been successfully rebased

@mergify mergify Bot merged commit 01b9c0d into python-wheel-build:main Apr 27, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants