docs: add environment variable filtering proposal#1084
docs: add environment variable filtering proposal#1084tiran wants to merge 1 commit intopython-wheel-build:mainfrom
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
smoparth
left a comment
smoparth
left a comment
There was a problem hiding this comment.
The proposal looks good overall. Just left a couple of comments requesting additional clarity on the evaluation order and the always-keep set.
Add proposal for configurable filtering of sensitive environment variables from subprocesses, modeled after sudo's env_keep/env_delete. See: python-wheel-build#1083 Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
filter-env-proposal
branch
from
9d8c27c to
5e86dec
Compare
tiran
changed the title
2 participants
Pull Request Description
What
Add proposal for configurable filtering of sensitive environment variables from subprocesses, modeled after sudo's env_keep/env_delete.
Why
See: #1083